Skip to content

Commit 52eaff1

Browse files
jersonalvaromb
authored andcommitted
Fix cant click on iOS (sbugert#70)
* Fix cant click on iOS the frame must be on self not in _bannerView * Update BannerView.m Improved code style * Update BannerView.m
1 parent a3d7b5b commit 52eaff1

File tree

1 file changed

+18
-17
lines changed

1 file changed

+18
-17
lines changed

ios/BannerView.m

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -54,13 +54,13 @@ - (GADAdSize)getAdSizeFromString:(NSString *)bannerSize
5454
return kGADAdSizeSmartBannerPortrait;
5555
} else if ([bannerSize isEqualToString:@"smartBannerLandscape"]) {
5656
return kGADAdSizeSmartBannerLandscape;
57-
}
58-
else {
57+
} else {
5958
return kGADAdSizeBanner;
6059
}
6160
}
6261

63-
-(void)loadBanner {
62+
-(void)loadBanner
63+
{
6464
if (_adUnitID && _bannerSize) {
6565
GADAdSize size = [self getAdSizeFromString:_bannerSize];
6666
_bannerView = [[GADBannerView alloc] initWithAdSize:size];
@@ -84,7 +84,6 @@ -(void)loadBanner {
8484
request.testDevices = @[_testDeviceID];
8585
}
8686
}
87-
8887
[_bannerView loadRequest:request];
8988
}
9089
}
@@ -100,36 +99,32 @@ - (void)setBannerSize:(NSString *)bannerSize
10099
}
101100
}
102101

103-
104-
105102
- (void)setAdUnitID:(NSString *)adUnitID
106103
{
107104
if(![adUnitID isEqual:_adUnitID]) {
108105
_adUnitID = adUnitID;
109106
if (_bannerView) {
110107
[_bannerView removeFromSuperview];
111108
}
112-
113109
[self loadBanner];
114110
}
115111
}
112+
116113
- (void)setTestDeviceID:(NSString *)testDeviceID
117114
{
118115
if(![testDeviceID isEqual:_testDeviceID]) {
119116
_testDeviceID = testDeviceID;
120117
if (_bannerView) {
121118
[_bannerView removeFromSuperview];
122119
}
123-
124120
[self loadBanner];
125121
}
126122
}
127123

128124
-(void)layoutSubviews
129125
{
130-
[super layoutSubviews ];
131-
132-
_bannerView.frame = CGRectMake(
126+
[super layoutSubviews];
127+
self.frame = CGRectMake(
133128
self.bounds.origin.x,
134129
self.bounds.origin.x,
135130
_bannerView.frame.size.width,
@@ -144,35 +139,41 @@ - (void)removeFromSuperview
144139
}
145140

146141
/// Tells the delegate an ad request loaded an ad.
147-
- (void)adViewDidReceiveAd:(GADBannerView *)adView {
142+
- (void)adViewDidReceiveAd:(GADBannerView *)adView
143+
{
148144
[_eventDispatcher sendInputEventWithName:@"onAdViewDidReceiveAd" body:@{ @"target": self.reactTag }];
149145
}
150146

151147
/// Tells the delegate an ad request failed.
152148
- (void)adView:(GADBannerView *)adView
153-
didFailToReceiveAdWithError:(GADRequestError *)error {
149+
didFailToReceiveAdWithError:(GADRequestError *)error
150+
{
154151
[_eventDispatcher sendInputEventWithName:@"onDidFailToReceiveAdWithError" body:@{ @"target": self.reactTag, @"error": [error localizedDescription] }];
155152
}
156153

157154
/// Tells the delegate that a full screen view will be presented in response
158155
/// to the user clicking on an ad.
159-
- (void)adViewWillPresentScreen:(GADBannerView *)adView {
156+
- (void)adViewWillPresentScreen:(GADBannerView *)adView
157+
{
160158
[_eventDispatcher sendInputEventWithName:@"onAdViewWillPresentScreen" body:@{ @"target": self.reactTag }];
161159
}
162160

163161
/// Tells the delegate that the full screen view will be dismissed.
164-
- (void)adViewWillDismissScreen:(GADBannerView *)adView {
162+
- (void)adViewWillDismissScreen:(GADBannerView *)adView
163+
{
165164
[_eventDispatcher sendInputEventWithName:@"onAdViewWillDismissScreen" body:@{ @"target": self.reactTag }];
166165
}
167166

168167
/// Tells the delegate that the full screen view has been dismissed.
169-
- (void)adViewDidDismissScreen:(GADBannerView *)adView {
168+
- (void)adViewDidDismissScreen:(GADBannerView *)adView
169+
{
170170
[_eventDispatcher sendInputEventWithName:@"onAdViewDidDismissScreen" body:@{ @"target": self.reactTag }];
171171
}
172172

173173
/// Tells the delegate that a user click will open another app (such as
174174
/// the App Store), backgrounding the current app.
175-
- (void)adViewWillLeaveApplication:(GADBannerView *)adView {
175+
- (void)adViewWillLeaveApplication:(GADBannerView *)adView
176+
{
176177
[_eventDispatcher sendInputEventWithName:@"onAdViewWillLeaveApplication" body:@{ @"target": self.reactTag }];
177178
}
178179

0 commit comments

Comments
 (0)