Fix for missing init for next order id. (#189)

* Fix for missing init for next order id. * Update audit.
mars-protocol · Dec 10, 2024 · 5334a9b · 5334a9b
1 parent 18e617a
commit 5334a9b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/.cargo/audit.toml b/.cargo/audit.toml
@@ -4,4 +4,4 @@
 # Ignore the following advisory IDs.
 # Reported vulnerabilities relate to test-tube which is only used for testing.
 # RUSTSEC-2024-0344 - no newer dependency fixing the issue in cosmwasm
-ignore = ["RUSTSEC-2024-0003", "RUSTSEC-2024-0006", "RUSTSEC-2024-0019", "RUSTSEC-2024-0332", "RUSTSEC-2024-0336", "RUSTSEC-2024-0344"]
+ignore = ["RUSTSEC-2024-0003", "RUSTSEC-2024-0006", "RUSTSEC-2024-0019", "RUSTSEC-2024-0332", "RUSTSEC-2024-0336", "RUSTSEC-2024-0344", "RUSTSEC-2024-0421"]
diff --git a/contracts/credit-manager/src/migrations/v2_2_0.rs b/contracts/credit-manager/src/migrations/v2_2_0.rs
@@ -4,6 +4,7 @@ use cw2::{assert_contract_version, set_contract_version};
 use crate::{
     contract::{CONTRACT_NAME, CONTRACT_VERSION},
     error::ContractError,
+    state::NEXT_TRIGGER_ID,
 };
 
 const FROM_VERSION: &str = "2.1.0";
@@ -12,6 +13,8 @@ pub fn migrate(deps: DepsMut) -> Result<Response, ContractError> {
     // make sure we're migrating the correct contract and from the correct version
     assert_contract_version(deps.storage, &format!("crates.io:{CONTRACT_NAME}"), FROM_VERSION)?;
 
+    NEXT_TRIGGER_ID.save(deps.storage, &1)?;
+
     set_contract_version(deps.storage, format!("crates.io:{CONTRACT_NAME}"), CONTRACT_VERSION)?;
 
     Ok(Response::new()

diff --git a/contracts/credit-manager/tests/tests/test_migration_v2.rs b/contracts/credit-manager/tests/tests/test_migration_v2.rs
@@ -1,6 +1,6 @@
 use cosmwasm_std::{attr, testing::mock_env, Empty, Event};
 use cw2::{ContractVersion, VersionError};
-use mars_credit_manager::{contract::migrate, error::ContractError};
+use mars_credit_manager::{contract::migrate, error::ContractError, state::NEXT_TRIGGER_ID};
 use mars_testing::mock_dependencies;
 
 #[test]
@@ -44,6 +44,9 @@ fn successful_migration() {
 
     let res = migrate(deps.as_mut(), mock_env(), Empty {}).unwrap();
 
+    let order_id = NEXT_TRIGGER_ID.load(deps.as_ref().storage).unwrap();
+    assert_eq!(order_id, 1);
+
     assert_eq!(res.messages, vec![]);
     assert_eq!(res.events, vec![] as Vec<Event>);
     assert!(res.data.is_none());