8344368: IndependenceSwingTest.java and IndependenceAWTTest.java failed: Selected text & clipboard contents differs

Reviewed-by: azvegint, dnguyen, prr, kizune

Author: Harshitha Onkar

test/jdk/java/awt/datatransfer/Independence/IndependenceAWTTest.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 1999, 2016, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1999, 2024, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -21,90 +21,112 @@
  * questions.
  */
 
-import java.awt.*;
-import java.awt.datatransfer.*;
-import java.awt.event.*;
-import java.util.Properties;
 
 /*
  * @test
  * @key headful
+ * @requires (os.family == "linux")
  * @summary To make sure that System & Primary clipboards should behave independently
- * @author Jitender([email protected]) area=AWT
- * @author [email protected]
  * @library /lib/client
  * @build ExtendedRobot
  * @run main IndependenceAWTTest
  */
 
-public class IndependenceAWTTest {
+import java.awt.BorderLayout;
+import java.awt.Color;
+import java.awt.EventQueue;
+import java.awt.Frame;
+import java.awt.HeadlessException;
+import java.awt.Panel;
+import java.awt.Point;
+import java.awt.TextField;
+import java.awt.Toolkit;
+import java.awt.datatransfer.Clipboard;
+import java.awt.datatransfer.DataFlavor;
+import java.awt.datatransfer.StringSelection;
+import java.awt.datatransfer.Transferable;
+import java.awt.event.FocusAdapter;
+import java.awt.event.FocusEvent;
+import java.awt.event.InputEvent;
+import java.awt.event.MouseEvent;
 
-    Frame frame;
-    Panel panel;
-    TextField tf1, tf2, tf3;
-    Clipboard sClip, pClip;
+public class IndependenceAWTTest {
+    private static Frame frame;
+    private static TextField tf1;
+    private static TextField tf2;
+    private static TextField tf3;
+    private static Clipboard systemClip;
+    private static Clipboard primaryClip;
+    private static ExtendedRobot robot;
+    private static volatile Point ttf1Center;
+    private static volatile Point glideStartLocation;
 
     public static void main (String[] args) throws Exception {
-        new IndependenceAWTTest().doTest();
+        try {
+            robot = new ExtendedRobot();
+            EventQueue.invokeAndWait(IndependenceAWTTest::createAndShowUI);
+            robot.waitForIdle();
+            robot.delay(1000);
+            test();
+        } finally {
+            EventQueue.invokeAndWait(frame::dispose);
+        }
     }
 
-    public IndependenceAWTTest() {
-
-        frame = new Frame();
+    private static void createAndShowUI() {
+        frame = new Frame("IndependenceAWTTest");
         frame.setSize(200, 200);
 
         // This textfield will be used to update the contents of clipboards
         tf1 = new TextField();
         tf1.addFocusListener(new FocusAdapter() {
             public void focusGained(FocusEvent fe) {
-                tf1.setText("Clipboards_Independance_Testing");
+                tf1.setText("Clipboards_Independence_Testing");
             }
         });
 
         // TextFields to get the contents of clipboard
         tf2 = new TextField();
         tf3 = new TextField();
 
-        panel = new Panel();
+        Panel panel = new Panel();
         panel.setLayout(new BorderLayout());
 
         panel.add(tf2, BorderLayout.NORTH);
         panel.add(tf3, BorderLayout.SOUTH);
 
         frame.add(tf1, BorderLayout.NORTH);
         frame.add(panel, BorderLayout.CENTER);
+        frame.setLocationRelativeTo(null);
 
         frame.setVisible(true);
         tf1.requestFocus();
     }
 
     // Get System Selection i.e. Primary Clipboard
-    private void getPrimaryClipboard() {
-        Properties ps = System.getProperties();
-        String operSys = ps.getProperty("os.name");
+    private static void getPrimaryClipboard() {
         try {
-            pClip = Toolkit.getDefaultToolkit().getSystemSelection();
-            if (pClip == null)
-                if ((operSys.substring(0,3)).equalsIgnoreCase("Win") || operSys.toLowerCase().contains("os x"))
-                    System.out.println(operSys + "Operating system does not support system selection ");
-                else
-                    throw new RuntimeException("Method getSystemSelection() is returning null on X11 platform");
-        } catch(HeadlessException e) {
+            primaryClip = Toolkit.getDefaultToolkit().getSystemSelection();
+            if (primaryClip == null) {
+                throw new RuntimeException("Method getSystemSelection() is returning null"
+                                           + " on Linux platform");
+            }
+        } catch (HeadlessException e) {
             System.out.println("Headless exception thrown " + e);
         }
     }
 
     // Method to get the contents of both of the clipboards
-    public void getClipboardsContent() throws Exception {
-        sClip = Toolkit.getDefaultToolkit().getSystemClipboard();
+    private static void getClipboardsContent() throws Exception {
+        systemClip = Toolkit.getDefaultToolkit().getSystemClipboard();
         Transferable tp;
         Transferable ts;
 
         StringSelection content = new StringSelection(tf1.getText());
-        sClip.setContents(content,content);
+        systemClip.setContents(content, content);
 
-        tp = pClip.getContents(this);
-        ts = sClip.getContents(this);
+        tp = primaryClip.getContents(null);
+        ts = systemClip.getContents(null);
 
         // Paste the contents of System clipboard on textfield tf2 while the paste the contents of
         // of primary clipboard on textfiled tf3
@@ -122,7 +144,7 @@ public void getClipboardsContent() throws Exception {
     }
 
     // Method to compare the Contents return by system & primary clipboard
-    public void compareText (boolean mustEqual) {
+    private static void compareText (boolean mustEqual) {
         if ((tf2.getText()).equals(tf3.getText())) {
             if (mustEqual)
                 System.out.println("Selected text & clipboard contents are same\n");
@@ -136,40 +158,39 @@ public void compareText (boolean mustEqual) {
         }
     }
 
-    public void doTest() throws Exception {
+    private static void test() throws Exception {
         getPrimaryClipboard();
-        ExtendedRobot robot = new ExtendedRobot();
-        robot.waitForIdle(1000);
-        frame.setLocation(100, 100);
-        robot.waitForIdle(1000);
-
-        if (pClip != null) {
-            Point ttf1Center = tf1.getLocationOnScreen();
-            ttf1Center.translate(tf1.getWidth()/2, tf1.getHeight()/2);
-
-            robot.glide(new Point(0, 0), ttf1Center);
-            robot.mousePress(InputEvent.BUTTON1_DOWN_MASK);
-            robot.waitForIdle(20);
-            robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
-            robot.waitForIdle(20);
-            robot.mousePress(InputEvent.BUTTON1_DOWN_MASK);
-            robot.waitForIdle(20);
-            robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
-            robot.waitForIdle(2000);
-
-            getClipboardsContent();
-            compareText(true);
-
-            //Change the text selection to update the contents of primary clipboard
-            robot.mouseMove(ttf1Center);
-            robot.mousePress(MouseEvent.BUTTON1_MASK);
-            robot.delay(200);
-            robot.mouseMove(ttf1Center.x + 15, ttf1Center.y);
-            robot.mouseRelease(MouseEvent.BUTTON1_MASK);
-            robot.waitForIdle(2000);
-
-            getClipboardsContent();
-            compareText(false);
-        }
+        robot.waitForIdle(500);
+
+        EventQueue.invokeAndWait(() -> {
+            Point center = tf1.getLocationOnScreen();
+            center.translate(tf1.getWidth() / 2, tf1.getHeight() / 2);
+            ttf1Center = center;
+
+            glideStartLocation = frame.getLocationOnScreen();
+            glideStartLocation.x -= 10;
+        });
+
+        robot.glide(glideStartLocation, ttf1Center);
+        robot.mousePress(InputEvent.BUTTON1_DOWN_MASK);
+        robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
+        robot.waitForIdle(20);
+        robot.mousePress(InputEvent.BUTTON1_DOWN_MASK);
+        robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);
+        robot.waitForIdle(500);
+
+        getClipboardsContent();
+        compareText(true);
+
+        //Change the text selection to update the contents of primary clipboard
+        robot.mouseMove(ttf1Center);
+        robot.mousePress(MouseEvent.BUTTON1_DOWN_MASK);
+        robot.delay(20);
+        robot.mouseMove(ttf1Center.x + 15, ttf1Center.y);
+        robot.mouseRelease(MouseEvent.BUTTON1_DOWN_MASK);
+        robot.waitForIdle(500);
+
+        getClipboardsContent();
+        compareText(false);
     }
 }