MDL-82657 qbank_managecategories: Check "includesubcategories" on reload

The "includesubcategories" parameter is passed in the URL as lowercase,
but the Javascript was looking for "includeSubcategories" in camel case.
This meant it was always being set as false (unchecked) even when the
URL said it was true.

This fixes the casing in the Javascript, and adds a behat test to
confirm the fix.

Author: marxjohnson

question/bank/managecategories/amd/build/datafilter/filtertypes/categories.min.js

@@ -31,9 +31,18 @@ export default class extends GenericFilter {
         includeSubcategories: 'input[name=category-subcategories]',
     };
 
-    constructor(filterType, rootNode, initialValues, filterOptions = {includeSubcategories: false}) {
+    /**
+     * Construct a new categoires filter
+     *
+     * @param {String} filterType The type of filter that this relates to (categories)
+     * @param {HTMLElement} rootNode The root node for the participants filterset
+     * @param {Array} initialValues The currently selected category IDs.
+     * @param {Object} filterOptions An object containing the additional options for the filter, currently "includesubcategories"
+     *     is supported, which if true will display the "Also show questions from subcategories" checkbox as checked.
+     */
+    constructor(filterType, rootNode, initialValues, filterOptions = {includesubcategories: false}) {
         super(filterType, rootNode, initialValues);
-        this.addSubcategoryCheckbox(filterOptions.includeSubcategories);
+        this.addSubcategoryCheckbox(filterOptions.includesubcategories);
     }
 
     async addSubcategoryCheckbox(checked = false) {

question/bank/managecategories/amd/build/datafilter/filtertypes/categories.min.js.map

@@ -107,3 +107,6 @@ Feature: A teacher can put questions in categories in the question bank
     When I set the field "Also show questions from subcategories" to "1"
     And I click on "Apply filters" "button"
     Then I should see "Question 1" in the "categoryquestions" "table"
+    When I reload the page
+    Then I should see "Question 1" in the "categoryquestions" "table"
+    And the field "Also show questions from subcategories" matches value "1"