Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setGlobalMetadatas does not remove "unused"/"extra" keywords after setting a new set of keywords with an inferior length #239

Open
pivilartisant opened this issue Feb 12, 2025 · 2 comments

Comments

@pivilartisant
Copy link
Collaborator

pivilartisant commented Feb 12, 2025

see: https://github.com/massalabs/DeWeb/blob/9faeabebd989e963e10583e1052a9b990e547a9e/cli/src/lib/website/metadata.ts#L82C23-L113

@damip
Copy link
Member

damip commented Feb 12, 2025

Note: this should be done by the front-end (listing existing keywords, updating the ones that are changed, removing extra ones). No need to touch the SC

@pivilartisant
Copy link
Collaborator Author

Note: this should be done by the front-end (listing existing keywords, updating the ones that are changed, removing extra ones). No need to touch the SC

Or in this case the function used in the lib :) (see description)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants