Skip to content

Commit a9efd4a

Browse files
authored
Merge pull request phpbb#6769 from rxu/ticket/17460
[ticket/17460] Fix fa-arrow-circle-up icon rendering in Quote BBCode
2 parents 485d72f + 353ea36 commit a9efd4a

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

phpBB/styles/prosilver/template/bbcode.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,11 @@
3838
<xsl:value-of select="$L_COLON"/>
3939
<xsl:if test="@post_url">
4040
<xsl:text> </xsl:text>
41-
<a href="{@post_url}" aria-label="{L_VIEW_QUOTED_POST}" data-post-id="{@post_id}" onclick="if(document.getElementById(hash.substr(1)))href=hash"><i class="icon fa-arrow-circle-up fa-fw" aria-hidden="true"></i></a>
41+
<a href="{@post_url}" aria-label="{L_VIEW_QUOTED_POST}" data-post-id="{@post_id}" onclick="if(document.getElementById(hash.substr(1)))href=hash"><i class="icon fa-arrow-circle-up fa-fw fas" aria-hidden="true"></i></a>
4242
</xsl:if>
4343
<xsl:if test="@msg_url">
4444
<xsl:text> </xsl:text>
45-
<a href="{@msg_url}" aria-label="{L_VIEW_QUOTED_POST}" data-msg-id="{@msg_id}"><i class="icon fa-arrow-circle-up fa-fw" aria-hidden="true"></i></a>
45+
<a href="{@msg_url}" aria-label="{L_VIEW_QUOTED_POST}" data-msg-id="{@msg_id}"><i class="icon fa-arrow-circle-up fa-fw fas" aria-hidden="true"></i></a>
4646
</xsl:if>
4747
<xsl:if test="@date">
4848
<span class="responsive-hide"><xsl:value-of select="@date"/></span>

tests/text_formatter/s9e/default_formatting_test.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@ public function get_default_formatting_tests()
283283
),
284284
array(
285285
'[quote=Username post_id=123]...[/quote]',
286-
'<blockquote cite="phpBB/viewtopic.php?p=123#p123"><div><cite>Username wrote: <a href="phpBB/viewtopic.php?p=123#p123" aria-label="VIEW_QUOTED_POST" data-post-id="123" onclick="if(document.getElementById(hash.substr(1)))href=hash"><i class="icon fa-arrow-circle-up fa-fw" aria-hidden="true"></i></a></cite>...</div></blockquote>'
286+
'<blockquote cite="phpBB/viewtopic.php?p=123#p123"><div><cite>Username wrote: <a href="phpBB/viewtopic.php?p=123#p123" aria-label="VIEW_QUOTED_POST" data-post-id="123" onclick="if(document.getElementById(hash.substr(1)))href=hash"><i class="icon fa-arrow-circle-up fa-fw fas" aria-hidden="true"></i></a></cite>...</div></blockquote>'
287287
),
288288
array(
289289
// Users are not allowed to submit their own URL for the post

0 commit comments

Comments
 (0)