Do not on final job retry failure

This way, a job that failed 5 times because of HTTP 5XX errors
should not appear as failed job in SolidQueue.

Author: oneiros

app/jobs/application_job.rb

@@ -6,7 +6,9 @@ class ApplicationJob < ActiveJob::Base
   retry_on ActiveRecord::Deadlocked
 
   # Retry on HTTP errors
-  retry_on HTTPX::HTTPError, wait: HTTP_5XX_RETRY_DELAY
+  retry_on(HTTPX::HTTPError, wait: HTTP_5XX_RETRY_DELAY) do |job, error|
+    # Do not raise the error on the final retry
+  end
 
   # Most jobs are safe to ignore if the underlying records are no longer available
   discard_on ActiveJob::DeserializationError