Skip to content

Commit 61c82f8

Browse files
committed
fix bug in tutorial and fix calc summary
1 parent 6ffb680 commit 61c82f8

File tree

5 files changed

+154
-129
lines changed

5 files changed

+154
-129
lines changed

src/atomate2/lobster/jobs.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,8 @@ def make(
7979
basis_dict: dict
8080
A dict including information on the basis set
8181
"""
82+
print(self.task_document_kwargs)
83+
8284
# copy previous inputs # VASP for example
8385
copy_lobster_files(wavefunction_dir)
8486

src/atomate2/lobster/schemas.py

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -597,6 +597,7 @@ def from_directory(
597597
"bva_comp": True,
598598
**calc_quality_kwargs,
599599
}
600+
print(calc_quality_kwargs_updated)
600601
cal_quality_dict = Analysis.get_lobster_calc_quality_summary(
601602
path_to_poscar=structure_path,
602603
path_to_vasprun=vasprun_path,
@@ -844,6 +845,7 @@ def from_directory(
844845
calc_quality_text = None
845846
describe = None
846847
describe_ionic = None
848+
print(analyze_outputs)
847849
if analyze_outputs:
848850
if (
849851
icohplist_path.exists()
@@ -872,16 +874,16 @@ def from_directory(
872874
lobsterpy_kwargs=lobsterpy_kwargs,
873875
which_bonds="cation-anion",
874876
)
875-
# Get lobster calculation quality summary data
877+
# Get lobster calculation quality summary data
876878

877-
calc_quality_summary = CalcQualitySummary.from_directory(
878-
dir_name,
879-
calc_quality_kwargs=calc_quality_kwargs,
880-
)
879+
calc_quality_summary = CalcQualitySummary.from_directory(
880+
dir_name,
881+
calc_quality_kwargs=calc_quality_kwargs,
882+
)
881883

882-
calc_quality_text = Description.get_calc_quality_description(
883-
calc_quality_summary.model_dump()
884-
)
884+
calc_quality_text = Description.get_calc_quality_description(
885+
calc_quality_summary.model_dump()
886+
)
885887

886888
# Read in charges
887889
charges = None
@@ -971,7 +973,7 @@ def from_directory(
971973
if describe_ionic is not None
972974
else None,
973975
strongest_bonds_cation_anion=sb_ionic,
974-
calc_quality_summary=calc_quality_summary,
976+
calc_quality_summary=calc_quality_summary if calc_quality_summary is not None else None,
975977
calc_quality_text=" ".join(calc_quality_text)
976978
if calc_quality_text is not None
977979
else None,

0 commit comments

Comments
 (0)