Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MigrationGraph component #254

Open
hmlli opened this issue Jul 16, 2022 · 2 comments
Open

MigrationGraph component #254

hmlli opened this issue Jul 16, 2022 · 2 comments

Comments

@hmlli
Copy link

hmlli commented Jul 16, 2022

Adding a component that deals with ion migration event visualizations. Works with MigrationGraph object from pymatgen-analysis-diffusion.

@mkhorton mkhorton changed the title migration_graph component MigrationGraph component Jul 18, 2022
@mkhorton
Copy link
Member

Thanks @hmlli! I added a "new-contributor" label to this issue for organizational purposes.

This PR will likely involve:

  • Addition of a new file, crystal_toolkit.renderables.migration_graph
  • Possibly the addition of a new MPComponent, to crystal_toolkit.components.migration_graph (depending on whether this can use the existing StructureMoleculeComponent or not, perhaps it can subclass)
  • A small example app in crystal_toolkit.apps.examples so that this can be added to the test suite and documentation

If you have any questions related to the above, please either ask them in this issue or contact privately.


Notice: Issues with the "new contributor" label are issues assigned to a specific individual who may either be a new contributor to this repository or who have only have had minimal prior experience. These issues refer to a specific pre-arranged set of action items, and are intended to welcome and onboard new developers. Please get in touch with [email protected] if you would like to get involved and want a similar "new contributor" issue assigned.

@hmlli
Copy link
Author

hmlli commented Jul 21, 2022

A WIP PR has been added to address this issue: #267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants