Jobconfig #817
Merged
Jobconfig #817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hello @utf, any chance you can have a look at this PR ? It should not change the default behavior of jobflow, just add an additional feature to it and we need it for jobflow-remote. |
Member
|
This looks great, thanks! |
Member
|
Just pushed a new version which should come out soon. |
Contributor
Thanks so much for the quick reply ! |
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the
update_configmethod it is only possible to fully overwrite each attribute of aJobConfig. This PR introduces the option to usedict_modupdates in changing the config to allow a finer tuning of theJobConfig.We need this in jobflow-remote, since otherwise each call to the
set_run_configfor a specific job overrides the settings from the previous calls.