Repository navigation
MemoryStore __eq__ does not behave as expected #788
Description
When two memory stores are instantiated with the same collection_name, they are isolated and do not interact with each other. When a document is inserted into one MemoryStore, it is not visible from the other MemoryStore. Therefore, one would expect that these stores are not equivalent and the MemoryStore.__eq__() should return False, but this is not the case. Is this intended behavior?
As an example:
from maggma.stores import MemoryStore
store1 = MemoryStore()
store2 = MemoryStore()
store1.connect()
store2.connect()
store1 == store2 # Returns True
store1.update([{"a": 1, "b": 2}, {"a": 2, "b": 3}], 'a')
store1.query_one() # Returns {"_id": <Object Id>, "a": 1, "b": 2}
store2.query_one() # Returns nothing
Activity
munrojm commentedon May 22, 2023
I see the issue here. This should definitely be fixed. Thanks for bringing it up.
rkingsbury commentedon Jul 21, 2023
I'm investigating some improvements to
MemoryStoreand will try to tackle this as part of that effort.rkingsbury commentedon Aug 25, 2023
@sivonxay if I am successful replacing
mongomock(see #846 ), then this behavior will change. TwoMemoryStoreinstantiated with the same collection name will actually point to the same collection and will evaluate as equal. If they are instantiated with different collection names, they will evaluate unequal.Does that behavior make sense to you?
sivonxay commentedon Aug 25, 2023
I think that sounds reasonable. That would be behavior I expect from the comparison
Preserve MemoryStore identity across serialization for MultiStore
Fix materialsproject#788: make MemoryStore equality reflect data isol…
Preserve MemoryStore identity across serialization for MultiStore