Skip to content
This repository was archived by the owner on Apr 9, 2025. It is now read-only.
This repository was archived by the owner on Apr 9, 2025. It is now read-only.

Validation Structures of None results in termination for PotentialTrainer #73

@danielsauceda

Description

@danielsauceda

It seems when doing

trainer = PotentialTrainer(
    potential=potential, optimizer=tf.keras.optimizers.Adam(1e-3)
)

That if no Validation sets are provided. then the entire endeavor fails. This would be because of difference in the Trainer class which has the following condition

          if has_validation:
                val_predictions = []
                val_targets = []
                for val_index, batch in enumerate(mgb_val):
                    graph_batch, target_batch = batch
                    if isinstance(graph_batch, MaterialGraph):

Whereas PotentialTrainer does not and attempts do.

            for batch_index, batch in enumerate(mgb_val):
                graph_batch, target_batch = batch

and since "mgb_val" is not set it fails since the "has_validation" condition is not utilized

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions