Skip to content
This repository was archived by the owner on Sep 4, 2024. It is now read-only.

Commit d9af961

Browse files
committed
Merge branch 'xbello-develop' into develop
* xbello-develop: fix: build_attrs is supposed to merge self.attrs and any supplied attrs Changed the build_attrs to work with Django==1.11. # Conflicts: # ajax_select/fields.py # tox.ini
2 parents e1d0d7b + 72abbe6 commit d9af961

File tree

2 files changed

+23
-15
lines changed

2 files changed

+23
-15
lines changed

ajax_select/fields.py

+7-4
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,9 @@ def __init__(self,
6161

6262
def render(self, name, value, attrs=None):
6363
value = value or ''
64-
final_attrs = self.build_attrs(attrs)
64+
65+
final_attrs = self.build_attrs(self.attrs)
66+
final_attrs.update(attrs or {})
6567
final_attrs.pop('required', None)
6668
self.html_id = final_attrs.pop('id', name)
6769

@@ -180,7 +182,8 @@ def render(self, name, value, attrs=None):
180182
if value is None:
181183
value = []
182184

183-
final_attrs = self.build_attrs(attrs)
185+
final_attrs = self.build_attrs(self.attrs)
186+
final_attrs.update(attrs or {})
184187
final_attrs.pop('required', None)
185188
self.html_id = final_attrs.pop('id', name)
186189

@@ -327,8 +330,8 @@ def __init__(self, channel, *args, **kwargs):
327330
def render(self, name, value, attrs=None):
328331

329332
initial = value or ''
330-
331-
final_attrs = self.build_attrs(attrs)
333+
final_attrs = self.build_attrs(self.attrs)
334+
final_attrs.update(attrs or {})
332335
self.html_id = final_attrs.pop('id', name)
333336
final_attrs.pop('required', None)
334337

tox.ini

+16-11
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
[tox]
88
envlist =
99
{py27,py34}-flake8,
10-
{py27,py34}-dj{17,18,19,110}
10+
{py27,py34}-{dj17,dj18,dj19,dj110,dj111}
1111
skip_missing_interpreters = true
1212

1313

@@ -17,29 +17,34 @@ setenv =
1717
PYTHONPATH = {toxinidir}:{toxinidir}/ajax_select:{toxinidir}/tests
1818
commands = django-admin.py test tests
1919
deps =
20-
dj16: Django>=1.6,<1.7
2120
dj17: Django>=1.7,<1.8
2221
dj18: Django>=1.8,<1.9
2322
dj19: Django>=1.9,<1.10
2423
dj110: Django>=1.10,<1.11
24+
dj111: Django>=1.11,<1.12
2525
; djmaster: https://github.com/django/django/zipball/master
2626

2727
[testenv:py27-flake8]
2828
deps =
2929
flake8
3030
commands = flake8 ajax_select tests example
3131

32-
[testenv:py33-flake8]
33-
deps =
34-
flake8
35-
commands = flake8 ajax_select tests example
36-
3732
[testenv:py34-flake8]
3833
deps =
3934
flake8
4035
commands = flake8 ajax_select tests example
4136

42-
[testenv:py35-flake8]
43-
deps =
44-
flake8
45-
commands = flake8 ajax_select tests example
37+
; [testenv:py35-flake8]
38+
; deps =
39+
; flake8
40+
; commands = flake8 ajax_select tests example
41+
;
42+
; [testenv:py36-flake8]
43+
; deps =
44+
; flake8
45+
; commands = flake8 ajax_select tests example
46+
;
47+
; [testenv:py37-flake8]
48+
; deps =
49+
; flake8
50+
; commands = flake8 ajax_select tests example

0 commit comments

Comments
 (0)