Skip to content

Commit 3e7ae53

Browse files
authored
apacheGH-42121: [Java] Cleanup spotless plugin configuration (apache#43019)
### What changes are included in this PR? As all modules have been migrated over to spotless, remove per-module configuration and enable java formatting at the root level. Exclude format module from java formatting but still enable license formatting for this module as well. ### Are these changes tested? Through CI/CD ### Are there any user-facing changes? No Fixes apache#42121 apache#40826 * GitHub Issue: apache#42121 Authored-by: Laurent Goujon <[email protected]> Signed-off-by: David Li <[email protected]>
1 parent fecd207 commit 3e7ae53

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

78 files changed

+960
-1459
lines changed

java/README.md

+1-4
Original file line numberDiff line numberDiff line change
@@ -66,10 +66,7 @@ rm -rf java/format/src
6666
flatc --java -o java/format/src/main/java format/*.fbs
6767

6868
# prepend license header
69-
find java/format/src -type f | while read file; do
70-
(cat header | while read line; do echo "// $line"; done; cat $file) > $file.tmp
71-
mv $file.tmp $file
72-
done
69+
mvn spotless:apply -pl :arrow-format
7370
```
7471

7572
## Performance Tuning

java/adapter/avro/pom.xml

-5
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,6 @@ under the License.
3232
<description>(Contrib/Experimental) A library for converting Avro data to Arrow data.</description>
3333
<url>http://maven.apache.org</url>
3434

35-
<properties>
36-
<checkstyle.config.location>dev/checkstyle/checkstyle-spotless.xml</checkstyle.config.location>
37-
<spotless.java.excludes>none</spotless.java.excludes>
38-
</properties>
39-
4035
<dependencies>
4136
<dependency>
4237
<groupId>org.apache.arrow</groupId>

java/adapter/jdbc/pom.xml

-5
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,6 @@ under the License.
3232
<description>(Contrib/Experimental)A library for converting JDBC data to Arrow data.</description>
3333
<url>http://maven.apache.org</url>
3434

35-
<properties>
36-
<checkstyle.config.location>dev/checkstyle/checkstyle-spotless.xml</checkstyle.config.location>
37-
<spotless.java.excludes>none</spotless.java.excludes>
38-
</properties>
39-
4035
<dependencies>
4136

4237
<dependency>

java/adapter/orc/pom.xml

-2
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,6 @@ under the License.
3535

3636
<properties>
3737
<arrow.cpp.build.dir>../../../cpp/release-build/</arrow.cpp.build.dir>
38-
<checkstyle.config.location>dev/checkstyle/checkstyle-spotless.xml</checkstyle.config.location>
39-
<spotless.java.excludes>none</spotless.java.excludes>
4038
</properties>
4139

4240
<dependencies>

java/algorithm/pom.xml

-5
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,6 @@ under the License.
2828
<name>Arrow Algorithms</name>
2929
<description>(Experimental/Contrib) A collection of algorithms for working with ValueVectors.</description>
3030

31-
<properties>
32-
<checkstyle.config.location>dev/checkstyle/checkstyle-spotless.xml</checkstyle.config.location>
33-
<spotless.java.excludes>none</spotless.java.excludes>
34-
</properties>
35-
3631
<dependencies>
3732
<dependency>
3833
<groupId>org.apache.arrow</groupId>

java/c/pom.xml

-2
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,6 @@ under the License.
3232

3333
<properties>
3434
<arrow.c.jni.dist.dir>./build</arrow.c.jni.dist.dir>
35-
<checkstyle.config.location>dev/checkstyle/checkstyle-spotless.xml</checkstyle.config.location>
36-
<spotless.java.excludes>none</spotless.java.excludes>
3735
</properties>
3836

3937
<dependencies>

java/compression/pom.xml

-5
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,6 @@ under the License.
2828
<name>Arrow Compression</name>
2929
<description>(Experimental/Contrib) A library for working with the compression/decompression of Arrow data.</description>
3030

31-
<properties>
32-
<checkstyle.config.location>dev/checkstyle/checkstyle-spotless.xml</checkstyle.config.location>
33-
<spotless.java.excludes>none</spotless.java.excludes>
34-
</properties>
35-
3631
<dependencies>
3732
<dependency>
3833
<groupId>org.apache.arrow</groupId>

java/dataset/pom.xml

-2
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ under the License.
3434
<arrow.cpp.build.dir>../../../cpp/release-build/</arrow.cpp.build.dir>
3535
<parquet.version>1.14.1</parquet.version>
3636
<avro.version>1.11.3</avro.version>
37-
<checkstyle.config.location>dev/checkstyle/checkstyle-spotless.xml</checkstyle.config.location>
38-
<spotless.java.excludes>none</spotless.java.excludes>
3937
</properties>
4038

4139
<dependencies>

java/dev/checkstyle/checkstyle-spotless.xml

-289
This file was deleted.

0 commit comments

Comments
 (0)