Skip to content

Commit 4663460

Browse files
apacheGH-46846: [CI][Dev] Fix shellcheck errors in the ci/scripts/install_dask.sh (apache#46847)
### Rationale for this change This is the sub issue apache#44748. * SC2102 (info): Ranges can only match single chars (mentioned due to duplicates). * SC2086 (info): Double quote to prevent globbing and word splitting. ``` shellcheck ci/scripts/install_dask.sh In ci/scripts/install_dask.sh line 33: pip install dask[dataframe] ^---------^ SC2102 (info): Ranges can only match single chars (mentioned due to duplicates). In ci/scripts/install_dask.sh line 35: pip install dask[dataframe]==${dask} ^---------^ SC2102 (info): Ranges can only match single chars (mentioned due to duplicates). ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pip install dask[dataframe]=="${dask}" For more information: https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... https://www.shellcheck.net/wiki/SC2102 -- Ranges can only match single char... ``` ### What changes are included in this PR? Quote varibles ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#46846 Authored-by: Hiroyuki Sato <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
1 parent 3573f54 commit 4663460

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

.pre-commit-config.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -315,6 +315,7 @@ repos:
315315
?^ci/scripts/install_chromedriver\.sh$|
316316
?^ci/scripts/install_cmake\.sh$|
317317
?^ci/scripts/install_conda\.sh$|
318+
?^ci/scripts/install_dask\.sh$|
318319
?^ci/scripts/install_emscripten\.sh$|
319320
?^ci/scripts/install_iwyu\.sh$|
320321
?^ci/scripts/install_ninja\.sh$|

ci/scripts/install_dask.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@ if [ "${dask}" = "upstream_devel" ]; then
3030
pip install "dask[dataframe] @ git+https://github.com/dask/dask.git"
3131
pip install -U git+https://github.com/dask-contrib/dask-expr.git
3232
elif [ "${dask}" = "latest" ]; then
33-
pip install dask[dataframe]
33+
pip install "dask[dataframe]"
3434
else
35-
pip install dask[dataframe]==${dask}
35+
pip install "dask[dataframe]==${dask}"
3636
fi
3737

3838
# additional dependencies needed for dask's s3 tests

0 commit comments

Comments
 (0)