Skip to content

Commit b684028

Browse files
authored
apacheGH-39859: [R] Remove macOS from the allow list (apache#39861)
Originally this was going to also bundle all of our dependencies to send to CRAN, but their webforms don't allow source tars that large (I tried down to 80MB which removed a large number of our dependencies, and that was still rejected by the macbuilder). This means that on CRAN, if there is no internet, the macOS binary will be minimal. But it means that we build on CRAN using source always. We should definitely submit this to macbuilder after this merges to main and confirm we get source build by default (since we look to the repo for our allowlist) * Closes: apache#39859 Authored-by: Jonathan Keane <[email protected]> Signed-off-by: Jonathan Keane <[email protected]>
1 parent 4ceb661 commit b684028

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

r/tools/nixlibs-allowlist.txt

-1
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,3 @@ ubuntu
22
centos
33
redhat
44
rhel
5-
darwin

r/tools/nixlibs.R

+1-1
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ check_allowlist <- function(os, allowed = "https://raw.githubusercontent.com/apa
222222
# Try a remote allowlist so that we can add/remove without a release
223223
suppressWarnings(readLines(allowed)),
224224
# Fallback to default: allowed only on Ubuntu and CentOS/RHEL
225-
error = function(e) c("ubuntu", "centos", "redhat", "rhel", "darwin")
225+
error = function(e) c("ubuntu", "centos", "redhat", "rhel")
226226
)
227227
# allowlist should contain valid regular expressions (plain strings ok too)
228228
any(grepl(paste(allowlist, collapse = "|"), os))

0 commit comments

Comments
 (0)