Skip to content

Commit c8f89d0

Browse files
authored
apacheGH-41720: [C++][Acero] Remove an useless parameter for QueryContext::Init called in hash_join_benchmark (apache#41716)
### Rationale for this change My local compilation parameters will include the compilation of some basic benchmarks. I discovered this compilation problem today. It seems that apache#41334 of `QueryContext::Init` is not synchronized to `hash_join_benchmark.cc`, and CI has not found this problem. . ### What changes are included in this PR? Remove the first arg . ### Are these changes tested? Needn't ### Are there any user-facing changes? No * GitHub Issue: apache#41720 Lead-authored-by: ZhangHuiGui <[email protected]> Co-authored-by: ZhangHuiGui <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
1 parent ecd769c commit c8f89d0

File tree

3 files changed

+3
-1
lines changed

3 files changed

+3
-1
lines changed

ci/scripts/cpp_build.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@ else
120120
-DARROW_BUILD_BENCHMARKS=${ARROW_BUILD_BENCHMARKS:-OFF} \
121121
-DARROW_BUILD_EXAMPLES=${ARROW_BUILD_EXAMPLES:-OFF} \
122122
-DARROW_BUILD_INTEGRATION=${ARROW_BUILD_INTEGRATION:-OFF} \
123+
-DARROW_BUILD_OPENMP_BENCHMARKS=${ARROW_BUILD_OPENMP_BENCHMARKS:-OFF} \
123124
-DARROW_BUILD_SHARED=${ARROW_BUILD_SHARED:-ON} \
124125
-DARROW_BUILD_STATIC=${ARROW_BUILD_STATIC:-ON} \
125126
-DARROW_BUILD_TESTS=${ARROW_BUILD_TESTS:-OFF} \

cpp/src/arrow/acero/hash_join_benchmark.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ class JoinBenchmark {
148148
};
149149

150150
scheduler_ = TaskScheduler::Make();
151-
DCHECK_OK(ctx_.Init(settings.num_threads, nullptr));
151+
DCHECK_OK(ctx_.Init(nullptr));
152152

153153
auto register_task_group_callback = [&](std::function<Status(size_t, int64_t)> task,
154154
std::function<Status(size_t)> cont) {

docker-compose.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -286,6 +286,7 @@ services:
286286
<<: [*common, *ccache, *sccache, *cpp]
287287
ARROW_BUILD_BENCHMARKS: "ON"
288288
ARROW_BUILD_EXAMPLES: "ON"
289+
ARROW_BUILD_OPENMP_BENCHMARKS: "ON"
289290
ARROW_ENABLE_TIMING_TESTS: # inherit
290291
ARROW_EXTRA_ERROR_CONTEXT: "ON"
291292
ARROW_MIMALLOC: "ON"

0 commit comments

Comments
 (0)