Skip to content

Commit f8d3b10

Browse files
authored
apacheGH-41590: [Java] Improve BaseRepeatedValueVector function on isEmpty and isNull operations (apache#41601)
### Rationale for this change Resolves apache#41590 . ### What changes are included in this PR? Make `abstract` on `isNull` and `isEmpty` of `BaseRepeatedValueVector`. ### Are these changes tested? Existing tests pass. ### Are there any user-facing changes? No. * GitHub Issue: apache#41590 Authored-by: Tai Le Manh <[email protected]> Signed-off-by: David Li <[email protected]>
1 parent 5255adc commit f8d3b10

File tree

1 file changed

+2
-10
lines changed

1 file changed

+2
-10
lines changed

java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueVector.java

+2-10
Original file line numberDiff line numberDiff line change
@@ -355,16 +355,8 @@ public int getInnerValueCountAt(int index) {
355355
offsetBuffer.getInt(index * OFFSET_WIDTH);
356356
}
357357

358-
/** Return if value at index is null (this implementation is always false). */
359-
@Override
360-
public boolean isNull(int index) {
361-
return false;
362-
}
363-
364-
/** Return if value at index is empty (this implementation is always false). */
365-
public boolean isEmpty(int index) {
366-
return false;
367-
}
358+
/** Return if value at index is empty. */
359+
public abstract boolean isEmpty(int index);
368360

369361
/** Starts a new repeated value. */
370362
public int startNewValue(int index) {

0 commit comments

Comments
 (0)