Skip to content

Commit 3975f2c

Browse files
committed
Update textractOpenAIEmbeddings.m
Adding extra tests to increase code coverage in extractOpenAIEmbeddings
1 parent 807b778 commit 3975f2c

File tree

1 file changed

+27
-3
lines changed

1 file changed

+27
-3
lines changed

tests/textractOpenAIEmbeddings.m

+27-3
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ function saveEnvVar(testCase)
1616
end
1717

1818
properties(TestParameter)
19-
InvalidInput = iGetInvalidInput;
19+
InvalidInput = iGetInvalidInput();
20+
ValidDimensionsModelCombinations = iGetValidDimensionsModelCombinations();
2021
end
2122

2223
methods(Test)
@@ -31,6 +32,18 @@ function keyNotFound(testCase)
3132
testCase.verifyError(@()extractOpenAIEmbeddings("bla"), "llms:keyMustBeSpecified");
3233
end
3334

35+
function validCombinationOfModelAndDimension(testCase, ValidDimensionsModelCombinations)
36+
testCase.verifyWarningFree(@()extractOpenAIEmbeddings("bla", ...
37+
Dimensions=ValidDimensionsModelCombinations.Dimensions,...
38+
ModelName=ValidDimensionsModelCombinations.ModelName, ...
39+
ApiKey="not-real"));
40+
end
41+
42+
function embedStringWithSuccessfulOpenAICall(testCase)
43+
testCase.verifyWarningFree(@()extractOpenAIEmbeddings("bla", ...
44+
ApiKey=getenv("OPENAI_KEY")));
45+
end
46+
3447
function invalidCombinationOfModelAndDimension(testCase)
3548
testCase.verifyError(@()extractOpenAIEmbeddings("bla", ...
3649
Dimensions=10,...
@@ -54,7 +67,7 @@ function testInvalidInputs(testCase, InvalidInput)
5467
end
5568
end
5669

57-
function invalidInput = iGetInvalidInput
70+
function invalidInput = iGetInvalidInput()
5871
invalidInput = struct( ...
5972
"InvalidEmptyText", struct( ...
6073
"Input",{{ "" }},...
@@ -117,4 +130,15 @@ function testInvalidInputs(testCase, InvalidInput)
117130
"InvalidApiKeySize",struct( ...
118131
"Input",{{"bla", "ApiKey" ["abc" "abc"] }},...
119132
"Error","MATLAB:validators:mustBeTextScalar"));
120-
end
133+
end
134+
135+
function validDimensionsModelCombinations = iGetValidDimensionsModelCombinations()
136+
validDimensionsModelCombinations = struct( ...
137+
"CaseTextEmbedding3Small", struct( ...
138+
"Dimensions",10,...
139+
"ModelName", "text-embedding-3-small"), ...
140+
...
141+
"CaseTextEmbedding3Large", struct( ...
142+
"Dimensions",10,...
143+
"ModelName", "text-embedding-3-large"));
144+
end

0 commit comments

Comments
 (0)