Skip to content

Commit c0321da

Browse files
committed
adjust to include graph, avoid infinite cache leak
1 parent 6689927 commit c0321da

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

data_prototype/artist.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -122,13 +122,13 @@ def pick(self, mouseevent, graph: Graph | None = None):
122122
# which do not have an axes property but children might
123123
a.pick(mouseevent, graph)
124124

125-
def _get_dynamic_graph(self, query):
125+
def _get_dynamic_graph(self, query, description, graph):
126126
return Graph([])
127127

128128
def _query_and_eval(self, container, requires, graph, cacheset=None):
129129
g = graph + self._graph
130130
query, q_cache_key = container.query(g)
131-
g = g + self._get_dynamic_graph(query)
131+
g = g + self._get_dynamic_graph(query, container.describe(), graph)
132132
g_cache_key = g.cache_key()
133133
cache_key = (g_cache_key, q_cache_key)
134134

@@ -141,9 +141,9 @@ def _query_and_eval(self, container, requires, graph, cacheset=None):
141141
conv = g.evaluator(container.describe(), requires)
142142
ret = conv.evaluate(query)
143143

144-
if cache is not None:
145-
cache[cache_key] = ret
146-
# TODO prune
144+
# TODO: actually add to cache and prune
145+
# if cache is not None:
146+
# cache[cache_key] = ret
147147

148148
return ret
149149

0 commit comments

Comments
 (0)