Skip to content

Commit 2a8d138

Browse files
committed
Remove unused 'close' arg to show().
For reference, _Backend_ipympl.show is effectively the function that pyplot.show calls (pyplot.show even copies the signature of the backend show). In af699c2, a 'close' kwarg was added to _Backend_ipympl.show, although any use of it was immediately removed in a subsequent commit (783419b). Still, this change means that calling e.g. `plt.show(True)`, for example, would no longer set `block=True`, but instead set `close=True`. As the change is relatively recent, it seems better to remove the unused 'close' kwarg again, which also makes the signature consistent with the builtin Matplotlib backends.
1 parent 47d83b1 commit 2a8d138

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

ipympl/backend_nbagg.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,7 @@ def destroy(event):
498498
return manager
499499

500500
@staticmethod
501-
def show(close=None, block=None):
501+
def show(block=None):
502502
# # TODO: something to do when keyword block==False ?
503503
interactive = is_interactive()
504504

0 commit comments

Comments
 (0)