Skip to content

Commit 28b05ca

Browse files
fix grammer; and add **make_addplot()** to TODO list
1 parent 449fe54 commit 28b05ca

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

examples/marketcolor_overrides.ipynb

+4-3
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,7 @@
357357
"1. It helps ensure that your marketcolor overrides are the same length as your dataframe, and\n",
358358
"2. It allows you to use the dataframe's `DatetimeIndex` in order to position the override values.\n",
359359
"\n",
360-
"#### Note that you will still have to pass the `marketcolor_overrides` as an separate iterable (apart from the dataframe)."
360+
"#### Note that you will still have to pass the `marketcolor_overrides` as a separate iterable (apart from the dataframe)."
361361
]
362362
},
363363
{
@@ -787,8 +787,9 @@
787787
"source": [
788788
"### TO DO:\n",
789789
"1. `marketcolor_overrides` should affect volume *when the override is a marketcolor object* that includes a 'volume' key.\n",
790-
"2. support \"hollow and filled\" candles.\n",
791-
"3. support renko and point-and-figure. This may be tricky (since one \"box\" may cover more and/or less than one date). Also, is support for marketcolor overrides even needed for renko and pnf? (find out from those who commonly use them)."
790+
"2. support `marketcolor_overrides` in **`mpf.make_addplot()`**\n",
791+
"3. support \"hollow and filled\" candles (both `mpf.plot()` and `mpf.make_addplot()`).\n",
792+
"4. support renko and point-and-figure. This may be tricky (since one \"box\" may cover more and/or less than one date). Also, is support for marketcolor overrides even needed for renko and pnf? (find out from those who commonly use them)."
792793
]
793794
},
794795
{

0 commit comments

Comments
 (0)