Skip to content

Commit 3e12ebf

Browse files
author
Ted
committed
swap scale for period, simplify isinstance checks, update version number
1 parent a59197d commit 3e12ebf

File tree

3 files changed

+9
-11
lines changed

3 files changed

+9
-11
lines changed

src/mplfinance/_arg_validators.py

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -110,23 +110,21 @@ def _mav_validator(mav_value):
110110
'''
111111
if isinstance(mav_value,int) and mav_value > 1:
112112
return True
113-
elif not isinstance(mav_value,tuple) and not isinstance(mav_value,list) and not isinstance(mav_value,dict):
113+
elif not isinstance(mav_value,(tuple,list,dict)):
114114
return False
115115

116116
if isinstance(mav_value,dict):
117-
if 'scale' not in mav_value or not (isinstance(mav_value['scale'],tuple) or\
118-
isinstance(mav_value['scale'],int) or isinstance(mav_value['scale'], list)):
117+
if 'period' not in mav_value or not isinstance(mav_value['period'],(tuple,list,dict)):
119118
return False
120119
if 'shift' in mav_value:
121-
if not (isinstance(mav_value['shift'],tuple) or isinstance(mav_value['shift'],int) or\
122-
isinstance(mav_value['shift'], list)):
120+
if not isinstance(mav_value['shift'],(tuple,list,dict)):
123121
return False
124-
if isinstance(mav_value['scale'], int) and isinstance(mav_value['shift'], int):
122+
if isinstance(mav_value['period'], int) and isinstance(mav_value['shift'], int):
125123
return True
126-
elif isinstance(mav_value['scale'], int) or isinstance(mav_value['shift'], int):
124+
elif isinstance(mav_value['period'], int) or isinstance(mav_value['shift'], int):
127125
return False
128-
if len(mav_value['scale']) == len(mav_value['shift']):
129-
for num in mav_value['scale']:
126+
if len(mav_value['period']) == len(mav_value['shift']):
127+
for num in mav_value['period']:
130128
if not isinstance(num, int) and num > 1:
131129
return False
132130
for num in mav_value['shift']:

src/mplfinance/plotting.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -981,7 +981,7 @@ def _plot_mav(ax,config,xdates,prices,apmav=None,apwidth=None):
981981
shift = None
982982
if isinstance(mavgs,dict):
983983
shift = mavgs['shift']
984-
mavgs = mavgs['scale']
984+
mavgs = mavgs['period']
985985
if isinstance(mavgs,int):
986986
mavgs = mavgs, # convert to tuple
987987
if len(mavgs) > 7:

tests/test_addplot.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,7 @@ def test_addplot12(bolldata):
362362
tname = os.path.join(tdir,fname)
363363
rname = os.path.join(refd,fname)
364364

365-
mpf.plot(df,type='candle',volume=True,savefig=tname,mav={'scale':(20,40,60), 'shift': [5,10,20]})
365+
mpf.plot(df,type='candle',volume=True,savefig=tname,mav={'period':(20,40,60), 'shift': [5,10,20]})
366366

367367
tsize = os.path.getsize(tname)
368368
print(glob.glob(tname),'[',tsize,'bytes',']')

0 commit comments

Comments
 (0)