Skip to content

Theme change doesn't work perfectly whilst widget is open. #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
samcunliffe opened this issue Jun 1, 2023 · 1 comment
Closed

Theme change doesn't work perfectly whilst widget is open. #140

samcunliffe opened this issue Jun 1, 2023 · 1 comment
Assignees
@Chris-N-K
Labels
Bug Something isn't working Styling Related to the visual appearance of the widget

Comments

@samcunliffe
Copy link
Collaborator

samcunliffe commented Jun 1, 2023 •
edited
Loading

Screen.Recording.2023-05-31.at.16.51.00.mov

Re-opening or doing something to the plot seems to fix.

Discussion in #138 (comment)_ and ff.

Also maybe related: when @dstansby switches to light theme, the background of the widget is not updated. At the moment I can't reproduce this. Separate comment in: #138 (comment)
@samcunliffe samcunliffe added the Bug Something isn't working label Jun 1, 2023
samcunliffe added a commit to samcunliffe/napari-matplotlib that referenced this issue Jun 1, 2023
@samcunliffe
Better variable names. Add a TODO note about matplotlib#140.
010a02e
@dstansby dstansby added the Styling Related to the visual appearance of the widget label Jun 13, 2023
@dstansby dstansby mentioned this issue Jun 20, 2023
Merged
2 tasks
@samcunliffe samcunliffe mentioned this issue Jan 11, 2024
Merged
@Chris-N-K
Copy link
Contributor

This should be fixed by merge #237.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chris-N-K Chris-N-K

Labels
Bug Something isn't working Styling Related to the visual appearance of the widget
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samcunliffe @dstansby @Chris-N-K