Skip to content

Axes text to show up in the test figure #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ruaridhg opened this issue May 10, 2023 · 3 comments · Fixed by #149
Closed

Axes text to show up in the test figure #96

ruaridhg opened this issue May 10, 2023 · 3 comments · Fixed by #149
Milestone
1.0.0

Comments

@ruaridhg
Copy link
Collaborator

No description provided.

@ruaridhg ruaridhg self-assigned this May 10, 2023
@dstansby dstansby added this to the 0.3.0 milestone May 18, 2023
@ruaridhg
Copy link
Collaborator Author

@dstansby for clarification axes text needs to appear in the below example:

Image

@dstansby
Copy link
Member

Yep (and the rest of them). Thinking about this, it's probably worth holding off on this until #2 has been done, and then it will be much easier because we can define a custom style sheet for the tests.

@ruaridhg
Copy link
Collaborator Author

Good point, when I was exploring options for this issue I came across style sheets so I'll hold off for now

@ruaridhg ruaridhg removed their assignment Jun 1, 2023
samcunliffe added a commit to samcunliffe/napari-matplotlib that referenced this issue Jun 2, 2023
@samcunliffe
Resolves matplotlib#96.
359a9fe 
Not a nice global fix, but by setting the test fixture viewer's theme to
light, napari-matplotlib will give axes dark grey axes, labels, and ticks.
samcunliffe added a commit to samcunliffe/napari-matplotlib that referenced this issue Jun 2, 2023
@samcunliffe
Resolves matplotlib#96.
2413b53 
Not a nice global fix, but by setting the test fixture viewer's theme to
light, napari-matplotlib will give axes dark grey axes, labels, and ticks.
@samcunliffe samcunliffe linked a pull request Jun 2, 2023 that will close this issue
Axis labels should respect the theme (#142) and fix #96 whilst I'm at it. #149
Merged
@samcunliffe samcunliffe mentioned this issue Jun 2, 2023
Merged
samcunliffe added a commit to samcunliffe/napari-matplotlib that referenced this issue Jun 2, 2023
@samcunliffe
Resolves matplotlib#96.
4af1c3f 
Not a nice global fix, but by setting the test fixture viewer's theme to
light, napari-matplotlib will give axes dark grey axes, labels, and ticks.
ruaridhg added a commit that referenced this issue Jun 5, 2023
@ruaridhg
Merge pull request #149 from samcunliffe/142-titles-not-respecting-theme
4a9a4da 
Axis labels should respect the theme (#142) and fix #96 whilst I'm at it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
napari-matplotlib plugin accelerator
Status: Done
Milestone
1.0.0
2 participants
@dstansby @ruaridhg