Add missing Clone, fix comments

S7evinK · S7evinK · commit c6eb79133c57 · 2024-01-18T08:18:26.000+01:00
diff --git a/federationapi/routing/routing.go b/federationapi/routing/routing.go
@@ -647,6 +647,8 @@ func MakeFedAPI(
 		// add the user to Sentry, if enabled
 		hub := sentry.GetHubFromContext(req.Context())
 		if hub != nil {
+			// clone the hub, so we don't send garbage events with e.g. mismatching rooms/event_ids
+			hub = hub.Clone()
 			hub.Scope().SetTag("origin", string(fedReq.Origin()))
 			hub.Scope().SetTag("uri", fedReq.RequestURI())
 		}
diff --git a/internal/httputil/httpapi.go b/internal/httputil/httpapi.go
@@ -76,7 +76,7 @@ func MakeAuthAPI(
 		// add the user to Sentry, if enabled
 		hub := sentry.GetHubFromContext(req.Context())
 		if hub != nil {
-			// clone the hub, so we don't sent garbage events with e.g. mismatching rooms/event_ids
+			// clone the hub, so we don't send garbage events with e.g. mismatching rooms/event_ids
 			hub = hub.Clone()
 			hub.Scope().SetUser(sentry.User{
 				Username: device.UserID,
diff --git a/relayapi/routing/routing.go b/relayapi/routing/routing.go
@@ -108,7 +108,7 @@ func MakeRelayAPI(
 		// add the user to Sentry, if enabled
 		hub := sentry.GetHubFromContext(req.Context())
 		if hub != nil {
-			// clone the hub, so we don't sent garbage events with e.g. mismatching rooms/event_ids
+			// clone the hub, so we don't send garbage events with e.g. mismatching rooms/event_ids
 			hub = hub.Clone()
 			hub.Scope().SetTag("origin", string(fedReq.Origin()))
 			hub.Scope().SetTag("uri", fedReq.RequestURI())

Original file line number	Diff line number	Diff line change
`@@ -647,6 +647,8 @@ func MakeFedAPI(`
`647`	`647`	`// add the user to Sentry, if enabled`
`648`	`648`	`hub := sentry.GetHubFromContext(req.Context())`
`649`	`649`	`if hub != nil {`
	`650`	`+ // clone the hub, so we don't send garbage events with e.g. mismatching rooms/event_ids`
	`651`	`+ hub = hub.Clone()`
`650`	`652`	`hub.Scope().SetTag("origin", string(fedReq.Origin()))`
`651`	`653`	`hub.Scope().SetTag("uri", fedReq.RequestURI())`
`652`	`654`	`}`