Skip to content

Commit 64eea45

Browse files
Tadeusz Sośnierztadzik
Tadeusz Sośnierz
andauthored
Fix matrix metrics handling (#869)
* Fix matrix metrics handling * Add changelog Co-authored-by: Tadeusz Sośnierz <[email protected]>
1 parent d582bc3 commit 64eea45

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

changelog.d/869.bugfix

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fix a crash caused by processing metrics for Matrix events.

src/metrics.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ export class PrometheusBridgeMetrics implements IBridgeMetrics {
6969
private remoteRequest: Histogram<string>;
7070
private matrixRequest: Histogram<string>;
7171
private requestsInFlight: Map<string, number>;
72-
private matrixRequestStatus: Map<string, "success"|"failed">;
72+
private matrixRequestStatus: Map<string, "success"|"failed"> = new Map();
7373
private httpServer: http.Server;
7474
private remoteMonthlyActiveUsers: Gauge<string>;
7575
private bridgeBlocked: Gauge<string>;
@@ -116,7 +116,7 @@ export class PrometheusBridgeMetrics implements IBridgeMetrics {
116116

117117
this.matrixRequest = new Histogram({
118118
help: "Histogram of processing durations of received Matrix messages",
119-
labelNames: ["outcome"],
119+
labelNames: ["outcome", "method"],
120120
name: "matrix_request_seconds",
121121
});
122122
register.registerMetric(this.matrixRequest);
@@ -208,7 +208,7 @@ export class PrometheusBridgeMetrics implements IBridgeMetrics {
208208
this.matrixRequestStatus.delete(context.uniqueId);
209209
this.matrixRequest.observe({
210210
method: context.functionName,
211-
result: successFail,
211+
outcome: successFail,
212212
}, timeMs);
213213
}
214214

0 commit comments

Comments
 (0)