Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Restore the method to retry sending of failed messages #3837

Closed
pixlwave opened this issue Aug 13, 2024 · 2 comments · Fixed by #3909
Closed

[Task] Restore the method to retry sending of failed messages #3837

pixlwave opened this issue Aug 13, 2024 · 2 comments · Fixed by #3909

Comments

@pixlwave
Copy link
Member

Part of the crypto work from element-hq/element-meta#2488

Whilst most send failures can be resolved automatically (e.g. network failures, invalid access token etc) or are deemed unrecoverable (e.g. invalid data, too large etc) there are some instances where a message can fail to send but may work later:

  • The other user was verified but has become unverified (will succeed when they're verified again).
  • The other user is verified but has an unverified device (will succeed when the device has been verified).

Having a method to retry sending of an item will be useful for this.

@bnjbvr
Copy link
Member

bnjbvr commented Aug 13, 2024

As the current timeline maintainer, I would consider this to be a regression, as the intent in terms of design is that the Timeline API is only a view onto the timeline events. Right now, this is not the case, but the overall effort of moving things out of the timeline into the send queue or into the event cache or other APIs would be wasted, if we restored that method to retry sending in the timeline itself. Let's not do this; can you think of an alternate way to do this?

@pixlwave pixlwave changed the title [Task] Restore the timeline method to retry sending of failed messages [Task] Restore the method to retry sending of failed messages Aug 13, 2024
@pixlwave
Copy link
Member Author

My bad, I shouldn't have specifically said the timeline.

As long as it exists on the room/send queue/timeline item/wherever that would be enough to allow the user to resend a message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants