chore: remove tracing::info usage (#578)

* chore: remove tracing::info in favour of pure stdout

* chore: linting

* chore: fix formatting

* feat: move to use shell io

* feat: introduce shell io abstraction for logging

* chore: remove clippy unused println

* chore: linting

* feat: make use of anstream and anystyle, remove use of atty

* chore: linting

* feat: turn tracing off by default, update messages

* chore: resolve conflicts

* chore: make requested changes

* chore: update pool_rs

* chore: linting, fix formatting. Remove uneeded colorize

* chore: make requested changes

* chore: linting

Author: dutterbutter

Cargo.lock

@@ -7,6 +7,7 @@ members = [
     "crates/core",
     "crates/l1_sidecar",
     "crates/types",
+    "crates/common",
 ]
 resolver = "2"
 
@@ -80,6 +81,8 @@ tracing-subscriber = { version = "0.3", features = [
     "local-time",
 ] }
 url = "2.5.4"
+anstream = "0.6.18"
+anstyle = "1.0.10"
 
 #########################
 # Test dependencies    #
@@ -98,3 +101,4 @@ anvil_zksync_config = { path = "crates/config" }
 anvil_zksync_core = { path = "crates/core" }
 anvil_zksync_l1_sidecar = { path = "crates/l1_sidecar" }
 anvil_zksync_types = { path = "crates/types" }
+anvil_zksync_common = { path = "crates/common" }

Cargo.toml

@@ -15,6 +15,7 @@ anvil_zksync_api_decl.workspace = true
 anvil_zksync_core.workspace = true
 anvil_zksync_l1_sidecar.workspace = true
 anvil_zksync_types.workspace = true
+anvil_zksync_common.workspace = true
 
 zksync_types.workspace = true
 zksync_web3_decl.workspace = true

crates/api_server/Cargo.toml

@@ -1,5 +1,6 @@
 use crate::error::RpcError;
 use anvil_zksync_api_decl::AnvilNamespaceServer;
+use anvil_zksync_common::sh_warn;
 use anvil_zksync_core::node::InMemoryNode;
 use anvil_zksync_types::api::{DetailedTransaction, ResetRequest};
 use anvil_zksync_types::Numeric;
@@ -100,9 +101,7 @@ impl AnvilNamespaceServer for AnvilNamespace {
     }
 
     async fn set_min_gas_price(&self, _gas: U256) -> RpcResult<()> {
-        tracing::info!(
-            "Setting minimum gas price is unsupported as ZKsync is a post-EIP1559 chain"
-        );
+        sh_warn!("Setting minimum gas price is unsupported as ZKsync is a post-EIP1559 chain");
         Err(RpcError::Unsupported.into())
     }
 

crates/api_server/src/impls/anvil.rs

@@ -16,6 +16,7 @@ anvil_zksync_config.workspace = true
 anvil_zksync_core.workspace = true
 anvil_zksync_l1_sidecar.workspace = true
 anvil_zksync_types.workspace = true
+anvil_zksync_common.workspace = true
 
 zksync_types.workspace = true
 

crates/cli/Cargo.toml

@@ -44,7 +44,7 @@ pub async fn override_bytecodes(node: &InMemoryNode, bytecodes_dir: String) -> a
                 node.override_bytecode(address, bytecode)
                     .await
                     .expect("Failed to override bytecode");
-                tracing::info!("+++++ Replacing bytecode at address {:?} +++++", address);
+                tracing::debug!("Replacing bytecode at address {:?}", address);
             }
         }
     }

crates/cli/src/bytecode_override.rs

@@ -1,5 +1,6 @@
 use crate::utils::parse_genesis_file;
 use alloy::signers::local::coins_bip39::{English, Mnemonic};
+use anvil_zksync_common::{sh_eprintln, sh_err};
 use anvil_zksync_config::constants::{
     DEFAULT_DISK_CACHE_DIR, DEFAULT_MNEMONIC, TEST_NODE_NETWORK_ID,
 };
@@ -440,7 +441,7 @@ impl Cli {
     /// Checks for deprecated options and warns users.
     pub fn deprecated_config_option() {
         if env::args().any(|arg| arg == "--config" || arg.starts_with("--config=")) {
-            eprintln!(
+            sh_eprintln!(
                 "Warning: The '--config' option has been removed. \
                 Please migrate to using other configuration options or defaults."
             );
@@ -611,28 +612,28 @@ impl PeriodicStateDumper {
         let state_bytes = match node.dump_state(preserve_historical_states).await {
             Ok(bytes) => bytes,
             Err(err) => {
-                tracing::error!("Failed to dump state: {:?}", err);
+                sh_err!("Failed to dump state: {:?}", err);
                 return;
             }
         };
 
         let mut decoder = GzDecoder::new(&state_bytes.0[..]);
         let mut json_str = String::new();
         if let Err(err) = decoder.read_to_string(&mut json_str) {
-            tracing::error!(?err, "Failed to decompress state bytes");
+            sh_err!("Failed to decompress state bytes: {}", err);
             return;
         }
 
         let state = match serde_json::from_str::<VersionedState>(&json_str) {
             Ok(state) => state,
             Err(err) => {
-                tracing::error!(?err, "Failed to parse state JSON");
+                sh_err!("Failed to parse state JSON: {}", err);
                 return;
             }
         };
 
         if let Err(err) = write_json_file(&dump_path, &state) {
-            tracing::error!(?err, "Failed to write state to file");
+            sh_err!("Failed to write state to file: {}", err);
         } else {
             tracing::trace!(path = ?dump_path, "Dumped state successfully");
         }

crates/cli/src/cli.rs

@@ -2,6 +2,7 @@ use crate::bytecode_override::override_bytecodes;
 use crate::cli::{Cli, Command, ForkUrl, PeriodicStateDumper};
 use crate::utils::update_with_fork_details;
 use anvil_zksync_api_server::NodeServerBuilder;
+use anvil_zksync_common::{sh_eprintln, sh_err, sh_warn};
 use anvil_zksync_config::constants::{
     DEFAULT_ESTIMATE_GAS_PRICE_SCALE_FACTOR, DEFAULT_ESTIMATE_GAS_SCALE_FACTOR,
     DEFAULT_FAIR_PUBDATA_PRICE, DEFAULT_L1_GAS_PRICE, DEFAULT_L2_GAS_PRICE, LEGACY_RICH_WALLETS,
@@ -62,7 +63,7 @@ async fn main() -> anyhow::Result<()> {
     let (fork_client, transactions_to_replay) = match command {
         Command::Run => {
             if config.offline {
-                tracing::warn!("Running in offline mode: default fee parameters will be used.");
+                sh_warn!("Running in offline mode: default fee parameters will be used.");
                 config = config
                     .clone()
                     .with_l1_gas_price(config.l1_gas_price.or(Some(DEFAULT_L1_GAS_PRICE)))
@@ -154,7 +155,7 @@ async fn main() -> anyhow::Result<()> {
         SystemContractsOptions::Local
     ) {
         if let Some(path) = env::var_os("ZKSYNC_HOME") {
-            tracing::info!("+++++ Reading local contracts from {:?} +++++", path);
+            tracing::debug!("Reading local contracts from {:?}", path);
         }
     }
 
@@ -265,7 +266,7 @@ async fn main() -> anyhow::Result<()> {
     // during replay. Otherwise, replay would send commands and hang.
     tokio::spawn(async move {
         if let Err(err) = node_executor.run().await {
-            tracing::error!("node executor ended with error: {:?}", err);
+            sh_err!("node executor ended with error: {:?}", err);
         }
     });
 
@@ -328,7 +329,7 @@ async fn main() -> anyhow::Result<()> {
                 server_handles.push(server.run());
             }
             Err(err) => {
-                tracing::info!(
+                sh_eprintln!(
                     "Failed to bind to address {}:{}: {}. Retrying with a different port...",
                     host,
                     config.port,

crates/cli/src/main.rs

@@ -0,0 +1,15 @@
+[package]
+name = "anvil_zksync_common"
+description = "anvil-zksync common"
+version.workspace = true
+edition.workspace = true
+authors.workspace = true
+homepage.workspace = true
+repository.workspace = true
+license.workspace = true
+keywords.workspace = true
+categories.workspace = true
+
+[dependencies]
+anstream.workspace = true
+anstyle.workspace = true

crates/common/Cargo.toml

@@ -0,0 +1 @@
+pub mod shell;