Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: evm_mine should produce non-empty blocks when it can #404

Closed
itegulov opened this issue Nov 22, 2024 · 0 comments · Fixed by #459
Closed

fix: evm_mine should produce non-empty blocks when it can #404

itegulov opened this issue Nov 22, 2024 · 0 comments · Fixed by #459
Assignees
@itegulov

Comments

@itegulov
Copy link
Contributor

Currently evm_mine always produces an empty block without looking at the mempool. This shouldn't be the case - we want evm_mine to take whatever it can from the mempool and produce a block that way; sort of how immediate sealing mode works in https://github.com/matter-labs/era-test-node/pull/392.
@itegulov itegulov converted this from a draft issue Nov 22, 2024
This was referenced Nov 22, 2024
Closed
Merged
@itegulov itegulov mentioned this issue Nov 29, 2024
Closed
@itegulov itegulov self-assigned this Dec 2, 2024
@itegulov itegulov moved this from Todo to In Progress in DevEx squad Dec 2, 2024
@itegulov itegulov mentioned this issue Dec 2, 2024
Merged
@itegulov itegulov moved this from In Progress to Done in DevEx squad Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@itegulov itegulov

Labels
None yet
Projects
DevEx squad
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make manual mining produce non-empty blocks matter-labs/anvil-zksync
1 participant
@itegulov