Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Keyboard Navigation when Sidecar Panel is focused #3

Open
FelipeRearden opened this issue Mar 1, 2024 · 11 comments

Comments

@FelipeRearden
Copy link

Hello @matthewturk !!!!

If possible, would you mind adding a simple keyboard navigation using when the focus is in the Sidecar Panel view.

I have long notes and would be spectacular to be able to “scroll” using the keyboard keys.


Thanks for reading this FR!
I hope you like my idea 🙏

@matthewturk
Copy link
Owner

Hi! Do you want the main note to scroll, or the sidecar panel?

@FelipeRearden
Copy link
Author

Hello @matthewturk !!!!

Thanks for the reply :)

Hi! Do you want the main note to scroll, or the sidecar panel?

The sidecar panel :)

@matthewturk
Copy link
Owner

Let me see what I can do! I honestly didn't realize it wouldn't scroll.

@matthewturk
Copy link
Owner

So I tried this out on my installation. I've got a really really long sidecar panel note, and I've focused the panel it's displayed in. Pressing up and down on my keyboard does scroll it. Am I misunderstanding?

@FelipeRearden
Copy link
Author

First of all forgive for the late reply, I literally burn my fingers while using the oven but I all good now 🙏

So I tried this out on my installation. I've got a really really long sidecar panel note, and I've focused the panel it's displayed in. Pressing up and down on my keyboard does scroll it. Am I misunderstanding?

I can confirm the same behavior on 0.2.4 using the mouse to focus on the sidecar panel and after hitting arrow keys.

I think the issue is on my end and I think I know why. I kindly ask some time before closing this issue because I wanna do some tests.

Sharing my thoughts: I think the issue happens only when you use the keyboard to focus on the sidecar panel. That’s why is not working on my end. Let me see what I can do and I get back to you :)

Thank you very much for the help 🙏

@matthewturk
Copy link
Owner

Oh, interesting! Maybe a hotkey to both focus the panel and focus the scrollable area would fix it?

@FelipeRearden
Copy link
Author

Oh, interesting! Maybe a hotkey to both focus the panel and focus the scrollable area would fix it?

That would be perfect @matthewturk !!! 🙏 🙏 🙏

This is exactly what we have for all Core Plugins that has Sidebar interfaces File Explorer , Tags and Bookmarks :

  • Show File Explorer , Show Tags and Show Bookmarks will focus on the Sidebar and focus on the first item in the Sidebar

I hope it is feasible to implement this 🙏

@matthewturk
Copy link
Owner

@FelipeRearden I think I have an idea, related to the navigation variable on the ItemView object. I'm working to test it.

@FelipeRearden
Copy link
Author

@FelipeRearden I think I have an idea, related to the navigation variable on the ItemView object. I'm working to test it.

Thank you very much @matthewturk !!!!! I hope you have success 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏

@matthewturk
Copy link
Owner

I wasn't totally able to fix this. I'm going to see if I can get #2 first.

@FelipeRearden
Copy link
Author

I wasn't totally able to fix this. I'm going to see if I can get #2 first.

Okay !!! Thank you very much for the feedback ☀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants