Skip to content

Commit 4a4f092

Browse files
committed
Auto merge of rust-lang#8096 - xFrednet:0000-remove-lintcheck-log-file, r=matthiaskrgr
Remove lintcheck log and add `--filter` option to lintcheck This PR removes the really outdated lintcheck log from this repo and adds a new `--filter` option to force warnings of a lint. This also ignores `allow` attributes. I believe that this is a good thing, as we'll see if suppressed false positives are also fixed by the changes. --- #### Example: ```sh $ cargo lintcheck --filter identity_op ``` #### Output ``` clippy 0.1.59 (460bef2 2021-12-08) [..]/cargo-0.49.0/src/cargo/core/compiler/fingerprint.rs:1910:17 clippy::identity_op "the operation is ineffective. Consider reducing it to `(ret[0] as usize)`" [..]/cargo-0.49.0/src/cargo/util/hex.rs:8:9 clippy::identity_op "the operation is ineffective. Consider reducing it to `num`" [..]/libc-0.2.81/src/unix/linux_like/linux/mod.rs:2654:18 clippy::identity_op "the operation is ineffective. Consider reducing it to `(dev & 0x00000000000000ff)`" [..]/libc-0.2.81/src/unix/linux_like/linux/mod.rs:2665:16 clippy::identity_op "the operation is ineffective. Consider reducing it to `(minor & 0x000000ff)`" [..]/libc-0.2.81/src/unix/linux_like/mod.rs:1218:27 clippy::identity_op "the operation is ineffective. Consider reducing it to `IPOPT_CONTROL`" [..]/rayon-1.5.0/src/slice/quicksort.rs:588:17 clippy::identity_op "the operation is ineffective. Consider reducing it to `len / 4`" [..]/regex-1.3.2/src/dfa.rs:1380:14 clippy::identity_op "the operation is ineffective. Consider reducing it to `(empty_flags.start as u8)`" Stats: clippy::identity_op 7 ICEs: ``` Two of these lints are suppressed when lintcheck runs normally --- changelog: none r? `@matthiaskrgr` Feel free to reassign if you think that someone else would be a better reviewer :upside_down_face:
2 parents 5abecad + e42f79c commit 4a4f092

File tree

3 files changed

+68
-3874
lines changed

3 files changed

+68
-3874
lines changed

.gitignore

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,11 @@ out
2727
# Generated by dogfood
2828
/target_recur/
2929

30+
# Generated by lintcheck
31+
/lintcheck-logs
32+
3033
# gh pages docs
3134
util/gh-pages/lints.json
32-
**/metadata_collection.json
3335

3436
# rustfmt backups
3537
*.rs.bk

0 commit comments

Comments
 (0)