You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello, I noticed that the sizes string in the Image component does not actually incorporate the sizes that are in the config and the default sizing doesn't really correlate to the sizes. The sizes attribute of a source should tell the browser when to load each image size and as is it does not. The MDN docs do a good job of explaining what the sizes attribute should be doing
Also, just wanna say I think this and you svelte waypoint components are great! I actually have a fork of each w/ some interesting (at least I think) upgrades
Here is my heavily modified svelte-image fork that allows passing options from the component level, noscript tags for ssr, lazy disabling, width/height replacement plus a few other things. Check it out, I'm happy to help move any of it into your code if you like https://github.com/nikse/svelte-image/tree/noscript-attribute-overrides-picture-fixes
Also modified svelte-waypoint to fit my needs and add an option to declare the offset via vh && a fix for the destroy callback within your use funcitonality there matyunya/svelte-waypoint@master...nikse:master
The text was updated successfully, but these errors were encountered:
Hello, I noticed that the sizes string in the Image component does not actually incorporate the sizes that are in the config and the default sizing doesn't really correlate to the sizes. The sizes attribute of a source should tell the browser when to load each image size and as is it does not. The MDN docs do a good job of explaining what the sizes attribute should be doing
https://developer.mozilla.org/en-US/docs/Learn/HTML/Multimedia_and_embedding/Responsive_images
Also, just wanna say I think this and you svelte waypoint components are great! I actually have a fork of each w/ some interesting (at least I think) upgrades
Here is my heavily modified svelte-image fork that allows passing options from the component level, noscript tags for ssr, lazy disabling, width/height replacement plus a few other things. Check it out, I'm happy to help move any of it into your code if you like https://github.com/nikse/svelte-image/tree/noscript-attribute-overrides-picture-fixes
Also modified svelte-waypoint to fit my needs and add an option to declare the offset via vh && a fix for the destroy callback within your use funcitonality there matyunya/svelte-waypoint@master...nikse:master
The text was updated successfully, but these errors were encountered: