more places

Author: mawinter69

core/src/main/resources/hudson/views/BuildButtonColumn/column.properties

@@ -23,4 +23,4 @@
 Task_scheduled={0} scheduled
 Schedule_a_task=Schedule a {1} for {0}
 Schedule_a_task_with_parameters=Schedule a {1} with parameters for {0}
-Task_schedule_failed=Failed to schedule build for {0}.
+Task_schedule_failed=Failed to schedule build for {0}

core/src/main/resources/hudson/views/BuildButtonColumn/icon.js

@@ -15,9 +15,9 @@ Behaviour.specify(
         headers: crumb.wrap({}),
       }).then((rsp) => {
         if (rsp.ok) {
-          notificationBar.show(message,notificationBar.SUCCESS);
+          notificationBar.show(message, notificationBar.SUCCESS);
         } else {
-          notificationBar.show(failure, notificationBar.ERROR)
+          notificationBar.show(failure, notificationBar.ERROR);
         }
       });
       return false;

core/src/main/resources/lib/hudson/project/configurable/configurable.js

@@ -11,9 +11,9 @@
         headers: crumb.wrap({}),
       }).then((rsp) => {
         if (rsp.ok) {
-          notificationBar.show(success,notificationBar.SUCCESS);
+          notificationBar.show(success, notificationBar.SUCCESS);
         } else {
-          notificationBar.show(failure, notificationBar.ERROR)
+          notificationBar.show(failure, notificationBar.ERROR);
         }
       });
       ev.preventDefault();

core/src/main/resources/lib/layout/task.jelly

@@ -186,6 +186,7 @@ THE SOFTWARE.
                      href="${href}"
                      class="task-link task-link-no-confirm ${isCurrent ? 'task-link--active' : ''}"
                      data-task-success="${%Done.}"
+                     data-task-failure="${%Failed.}"
                      data-task-post="${attrs.post}"
                      ATTRIBUTES="${attrs}"
                      EXCEPT="badge confirmationMessage contextMenu destructive enabled href icon permission permissions post requiresConfirmation title">

core/src/main/resources/lib/layout/task/task.js

@@ -6,6 +6,7 @@ Behaviour.specify("a.task-link-no-confirm", "task-link", 0, function (el) {
   let post = el.dataset.taskPost;
   let callback = el.dataset.callback;
   let success = el.dataset.taskSuccess;
+  let failure = el.dataset.taskFailure;
   let href = el.href;
 
   if (callback !== undefined) {
@@ -20,8 +21,13 @@ Behaviour.specify("a.task-link-no-confirm", "task-link", 0, function (el) {
       fetch(href, {
         method: "post",
         headers: crumb.wrap({}),
+      }).then((rsp) => {
+        if (rsp.ok) {
+          notificationBar(success, notificationBar.SUCCESS);
+        } else {
+          notificationBar(failure, notificationBar.ERROR);
+        }
       });
-      hoverNotification(success, el.parentNode);
       ev.preventDefault();
     };
   }

war/src/main/js/components/dropdowns/jumplists.js

@@ -105,11 +105,19 @@ function mapChildrenItemsToDropdownItems(items) {
             fetch(item.url, {
               method: "post",
               headers: crumb.wrap({}),
+            }).then((rsp) => {
+              if (rsp.ok) {
+                notificationBar.show(
+                  item.displayName + ": Done.",
+                  notificationBar.SUCCESS,
+                );
+              } else {
+                notificationBar.show(
+                  item.displayName + ": Failed.",
+                  notificationBar.ERROR,
+                );
+              }
             });
-            notificationBar.show(
-              item.displayName + ": Done.",
-              notificationBar.SUCCESS,
-            );
           }
         }
       },