Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ComputationContext::set_fallback_generator #100

Open
maximmaxim345 opened this issue Feb 3, 2025 · 0 comments
Open

Improve ComputationContext::set_fallback_generator #100

maximmaxim345 opened this issue Feb 3, 2025 · 0 comments
Labels
component: computegraph

Comments

@maximmaxim345
Copy link
Owner

#90 introduced ComputationContext::set_fallback_generator, but directly returning the nodes input parameter has a major issue:
It is impossible to definitely know if a node was run, making CacheValidator::was_accessed (from #99) unreliable.
@maximmaxim345 maximmaxim345 mentioned this issue Feb 22, 2025
Merged
maximmaxim345 added a commit that referenced this issue Feb 22, 2025
@maximmaxim345
feat(viewport): add caching support for Viewports (#105)
2056472 
This PR adds a efficient caching system for the `Viewport` widget.
Only the minimal set of nodes is now rerun on changes to the passed in
`ProjectView`, considerably speeding up the viewport.
Caching is applied to both the `ViewportPlugins`, and the `SceneGraph`.

To test it, the `cadara` binary now shows a slowly growing cube.

While there are still some issues left to solve (#100 and #104), this
implementation should be enough for the time being.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: computegraph
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maximmaxim345