test: Clean up e2e and disable snapshot tests for now

maxmilton · Jul 14, 2024 · 3c841b8 · 3c841b8
1 parent c8d5453
commit 3c841b8
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 23 deletions.
diff --git a/playwright.config.ts b/playwright.config.ts
@@ -1,14 +1,18 @@
 import { defineConfig } from '@playwright/test';
 
 export default defineConfig({
+  testDir: 'test/e2e',
   testMatch: 'test/e2e/**/*.spec.ts',
+  snapshotPathTemplate: 'test/e2e/snapshots/{testFilePath}/{arg}{ext}',
   forbidOnly: !!process.env.CI,
+  retries: process.env.CI ? 2 : 0,
   use: {
     acceptDownloads: false,
     contextOptions: { strictSelectors: true },
     locale: 'en-US',
     offline: true, // the extension must work 100% offline
     timezoneId: 'UTC',
+    trace: 'on-first-retry',
   },
   expect: {
     toHaveScreenshot: {

diff --git a/test/e2e/newtab.spec.ts b/test/e2e/newtab.spec.ts
@@ -20,12 +20,6 @@ import { expect, test } from './fixtures';
 //  - No external requests
 
 test('newtab page', async ({ page, extensionId }) => {
-  await page.addInitScript(() => {
-    const style = document.createElement('style');
-    style.textContent = "body { font-family: 'Noto Sans', Arial, sans-serif !important; }";
-    document.head.appendChild(style);
-  });
-
   await page.goto(`chrome-extension://${extensionId}/newtab.html`);
 
   await expect(page).toHaveTitle('New Tab');
@@ -55,21 +49,17 @@ test('newtab page', async ({ page, extensionId }) => {
   // await expect(menuDropdown).not.toBeVisible();
 
   // TODO: More and better assertions.
-
-  // FIXME: Remove!!!!!!!
-  const fontFamily = await page.evaluate(() => getComputedStyle(document.body).fontFamily);
-  console.log('Body font family:', fontFamily);
 });
 
-test('matches screenshot', async ({ page, extensionId }) => {
-  await page.addInitScript(() => {
-    const style = document.createElement('style');
-    style.textContent = "body { font-family: 'Noto Sans', Arial, sans-serif !important; }";
-    document.head.appendChild(style);
-  });
+test.skip('matches screenshot', async ({ page, extensionId }) => {
+  // await page.addInitScript(() => {
+  //   const style = document.createElement('style');
+  //   style.textContent = "body { font-family: 'Noto Sans', Arial, sans-serif !important; }";
+  //   document.head.appendChild(style);
+  // });
 
   await page.goto(`chrome-extension://${extensionId}/newtab.html`);
-  await expect(page).toHaveScreenshot('newtab-default.png', { fullPage: true });
+  await expect(page).toHaveScreenshot('newtab-default.png');
 });
 
 test('has no console calls or unhandled errors', async ({ page, extensionId }) => {

diff --git a/test/e2e/newtab.spec.ts-snapshots/newtab-default-linux.png b/test/e2e/newtab.spec.ts-snapshots/newtab-default-linux.png
diff --git a/test/e2e/settings.spec.ts b/test/e2e/settings.spec.ts
@@ -15,15 +15,11 @@ test('settings page', async ({ page, extensionId }) => {
   await expect(labels[1]).toHaveText('Show bookmarks bar');
   await expect(labels[2]).toHaveText('Sections');
   await expect(labels[3]).toHaveText('Reset');
-
-  // FIXME: Remove!!!!!!!
-  const fontFamily = await page.evaluate(() => getComputedStyle(document.body).fontFamily);
-  console.log('Body font family:', fontFamily);
 });
 
-test('matches screenshot', async ({ page, extensionId }) => {
+test.skip('matches screenshot', async ({ page, extensionId }) => {
   await page.goto(`chrome-extension://${extensionId}/settings.html`);
-  await expect(page).toHaveScreenshot('settings-default.png', { fullPage: true });
+  await expect(page).toHaveScreenshot('settings-default.png');
 });
 
 test('has no console calls or unhandled errors', async ({ page, extensionId }) => {

diff --git a/test/e2e/settings.spec.ts-snapshots/settings-default-linux.png b/test/e2e/settings.spec.ts-snapshots/settings-default-linux.png