From 0998ba2b206683dee7f95c653c77e8e96e61b354 Mon Sep 17 00:00:00 2001 From: Sven van de Scheur Date: Thu, 30 Jan 2025 15:51:00 +0100 Subject: [PATCH] :bug: - fix: fix a bug that could cause the DataRangeInput component not to respond to value changes if the updated value was empty --- src/components/form/dateinput/dateinput.tsx | 5 ++++- src/components/form/daterangeinput/daterangeinput.tsx | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/components/form/dateinput/dateinput.tsx b/src/components/form/dateinput/dateinput.tsx index c87e66e7..cd41d49c 100644 --- a/src/components/form/dateinput/dateinput.tsx +++ b/src/components/form/dateinput/dateinput.tsx @@ -134,6 +134,7 @@ export const DateInput: React.FC = ({ // Update sanitizedValuesState. useEffect(() => { if (!value) { + setSanitizedValuesState(undefined); return; } const date = value2Date(value); @@ -261,9 +262,11 @@ export const DateInput: React.FC = ({ dispatchEvent(dateString); setIsPristine(false); } else { + if (isPristine) { + return; + } // Date is invalid after previous valid value, dispatch "". dispatchEvent(""); - setIsPristine(false); } }, [sanitizedValuesState, isPristine, dispatchEvent], diff --git a/src/components/form/daterangeinput/daterangeinput.tsx b/src/components/form/daterangeinput/daterangeinput.tsx index 9ba9a369..5a3f71bf 100644 --- a/src/components/form/daterangeinput/daterangeinput.tsx +++ b/src/components/form/daterangeinput/daterangeinput.tsx @@ -104,6 +104,7 @@ export const DateRangeInput: React.FC = ({ .map(date2DateString); if (!dates?.length || (dates?.length && dates?.length < 2)) { + setValuesState(undefined); return; }