Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error running check-manifest #3

Open
jayvdb opened this issue Jan 5, 2020 · 7 comments
Open

Error running check-manifest #3

jayvdb opened this issue Jan 5, 2020 · 7 comments

Comments

@jayvdb
Copy link
Contributor

jayvdb commented Jan 5, 2020

> python3 -m check_manifest -u
['/usr/bin/python3', 'setup.py', 'sdist', '-d', '/tmp/check-manifest-6wigkwia-sdist'] failed (status 1):
Traceback (most recent call last):
  File "setup.py", line 33, in <module>
    Package.setup()
  File "/tmp/check-manifest-ar9ccg4n-sources/setup_boilerplate.py", line 303, in setup
    cls.prepare()
  File "/tmp/check-manifest-ar9ccg4n-sources/setup_boilerplate.py", line 290, in prepare
    cls.version = find_version(cls.name)
  File "/tmp/check-manifest-ar9ccg4n-sources/setup_boilerplate.py", line 57, in find_version
    version_module_vars = runpy.run_path(version_module_path)
  File "/usr/lib64/python3.7/runpy.py", line 263, in run_path
    pkg_name=pkg_name, script_name=fname)
  File "/usr/lib64/python3.7/runpy.py", line 96, in _run_module_code
    mod_name, mod_spec, pkg_name, script_name)
  File "/usr/lib64/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "version_query/_version.py", line 5, in <module>
    VERSION = predict_version_str()
  File "/tmp/check-manifest-ar9ccg4n-sources/version_query/query.py", line 75, in predict_version_str
    return predict_caller(2).to_str()
  File "/tmp/check-manifest-ar9ccg4n-sources/version_query/query.py", line 71, in predict_caller
    return predict_folder(here, True)
  File "/tmp/check-manifest-ar9ccg4n-sources/version_query/query.py", line 65, in predict_folder
    return query_folder(path, search_parent_directories=search_parent_directories)
  File "/tmp/check-manifest-ar9ccg4n-sources/version_query/query.py", line 37, in query_folder
    return query_package_folder(path, search_parent_directories=search_parent_directories)
  File "/tmp/check-manifest-ar9ccg4n-sources/version_query/py_query.py", line 42, in query_package_folder
    raise ValueError(paths, metadata_json_paths, pkg_info_paths)
ValueError: ([PosixPath('/tmp/check-manifest-ar9ccg4n-sources/version_query'), PosixPath('/tmp/check-manifest-ar9ccg4n-sources'), PosixPath('/tmp'), PosixPath('/')], [], [])
@mbdevpl
Copy link
Owner

mbdevpl commented Jan 6, 2020

Where does that "check_manifest" come from? On my system there's no such module.

@jayvdb
Copy link
Contributor Author

jayvdb commented Jan 6, 2020

It comes from https://pypi.org/project/check-manifest/

@mbdevpl
Copy link
Owner

mbdevpl commented Jan 6, 2020

I see. I never used this package.

It's unclear to me whether this means that the check-manifest package should be fixed, or my package should be fixed? And what should be the correct behaviour/output?

@mbdevpl
Copy link
Owner

mbdevpl commented Jan 6, 2020

Have you read about limitations of version-query https://github.com/mbdevpl/version-query#limitations and are you sure if check-manifest doesn't violate the rules described there?

@jayvdb
Copy link
Contributor Author

jayvdb commented Jan 6, 2020

It is a tool which fixes the MANIFEST.in in a project repository, by executing setup.py.

I am running it inside the git repository - that is mandatory for check-manifest to do its job.

@mbdevpl
Copy link
Owner

mbdevpl commented Jan 7, 2020

I see. Well, the errors seem to be originating from /tmp directory... My guess is that check-manifest is copying the files of the project into some temporary directory and trying to build the sdist there, and thus the version-query fails.

@jayvdb
Copy link
Contributor Author

jayvdb commented Jan 7, 2020

ok, yea, that could be it. I'll dig into this a bit more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants