fix: some better typing

Author: mbifulco

src/lib/blog.ts

@@ -1,24 +1,24 @@
 // Install gray-matter and date-fns
 import { join } from 'path';
 
+import { ContentTypes } from '../data/content-types';
 import type { BlogPost } from '../data/content-types';
 import { getAllContentFromDirectory } from './content-loaders/getAllContentFromDirectory';
 import { getContentBySlug } from './content-loaders/getContentBySlug';
 
 // Add markdown files in `src/content/blog`
 const postsDirectory = join(process.cwd(), 'src', 'data', 'posts');
-const POST_CONTENT_TYPE = 'post';
 
 export const getPostBySlug = async (slug: string) => {
-  const post = await getContentBySlug(slug, postsDirectory, POST_CONTENT_TYPE);
+  const post = await getContentBySlug(slug, postsDirectory, ContentTypes.Post);
 
   return post as BlogPost;
 };
 
 export const getAllPosts = async () => {
   const allPosts = (await getAllContentFromDirectory(
     postsDirectory,
-    POST_CONTENT_TYPE
+    ContentTypes.Post
   )) as BlogPost[];
 
   return allPosts;

src/lib/content-loaders/getContentBySlug.ts

@@ -1,7 +1,7 @@
 import fs from 'fs';
 import { join } from 'path/posix';
 
-import type { MarkdownDocument } from '@data/content-types';
+import type { ContentType, MarkdownDocument } from '@data/content-types';
 import { processMDXFileContent } from './processMDXFileContent';
 
 /**
@@ -16,7 +16,7 @@ import { processMDXFileContent } from './processMDXFileContent';
 export const getContentBySlug = async (
   slug: string,
   directory: fs.PathLike,
-  type: string
+  type: ContentType
 ): Promise<MarkdownDocument> => {
   try {
     const realSlug = slug.replace(/\.mdx$/, '');

src/lib/external-references.ts

@@ -1,5 +1,6 @@
 import { join } from 'path';
 
+import { ContentTypes } from '../data/content-types';
 import type { Article } from '../data/content-types';
 import { getAllContentFromDirectory } from './content-loaders/getAllContentFromDirectory';
 import { getContentBySlug } from './content-loaders/getContentBySlug';
@@ -12,21 +13,19 @@ const externalReferencesDirectory = join(
   'external-references'
 );
 
-const EXTERNAL_REFERENCES_CONTENT_TYPE = 'article';
-
 export const getExternalReferenceBySlug = async (slug: string) => {
   const reference = await getContentBySlug(
     slug,
     externalReferencesDirectory,
-    EXTERNAL_REFERENCES_CONTENT_TYPE
+    ContentTypes.Article
   );
   return reference as Article;
 };
 
 export const getAllExternalReferences = async () => {
   let articles = (await getAllContentFromDirectory(
     externalReferencesDirectory,
-    EXTERNAL_REFERENCES_CONTENT_TYPE
+    ContentTypes.Article
   )) as Article[];
 
   // filter out articles that don't have a slug

src/lib/newsletters.ts

@@ -1,5 +1,6 @@
 import { join } from 'path';
 
+import { ContentTypes } from '../data/content-types';
 import type { MarkdownDocument, Newsletter } from '../data/content-types';
 import { getAllContentFromDirectory } from './content-loaders/getAllContentFromDirectory';
 import { getContentBySlug } from './content-loaders/getContentBySlug';
@@ -12,8 +13,6 @@ export const newslettersDirectory = join(
   'newsletters'
 );
 
-export const NEWSLETTERS_CONTENT_TYPE = 'newsletter';
-
 // Helper function to safely process raw content into newsletters
 export const processNewslettersContent = (
   rawContent: MarkdownDocument[]
@@ -55,7 +54,7 @@ export const getNewsletterBySlug = async (slug: string) => {
   const reference = await getContentBySlug(
     slug,
     newslettersDirectory,
-    NEWSLETTERS_CONTENT_TYPE
+    ContentTypes.Newsletter
   );
   return reference as Newsletter;
 };
@@ -64,7 +63,7 @@ export const getAllNewsletters = async () => {
   try {
     const rawContent = await getAllContentFromDirectory(
       newslettersDirectory,
-      NEWSLETTERS_CONTENT_TYPE
+      ContentTypes.Newsletter
     );
     return processNewslettersContent(rawContent);
   } catch (error) {