Skip to content

Commit 76d30ca

Browse files
authored
Attach html element before calling on create li (#846)
* Attach html element before calling onCreateLi * Build
1 parent 97fb9a5 commit 76d30ca

File tree

5 files changed

+15
-8
lines changed

5 files changed

+15
-8
lines changed

src/elementsRenderer.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,6 @@ export default class ElementsRenderer {
9595
const li = this.createLi(child, level);
9696
ul.appendChild(li);
9797

98-
this.attachNodeData(child, li);
99-
10098
if (child.hasChildren()) {
10199
this.createDomElements(li, child.children, false, level + 1);
102100
}
@@ -156,6 +154,10 @@ export default class ElementsRenderer {
156154
return li;
157155
}
158156

157+
/* Create the <li> element
158+
* Attach it to node.element.
159+
* Call onCreateLi
160+
*/
159161
private createLi(node: Node, level: number): HTMLLIElement {
160162
const isSelected = Boolean(this.isNodeSelected(node));
161163

@@ -166,6 +168,8 @@ export default class ElementsRenderer {
166168
? this.createFolderLi(node, level, isSelected)
167169
: this.createNodeLi(node, level, isSelected);
168170

171+
this.attachNodeData(node, li);
172+
169173
if (this.onCreateLi) {
170174
this.onCreateLi(node, jQuery(li), isSelected);
171175
}
@@ -339,7 +343,6 @@ export default class ElementsRenderer {
339343

340344
// create element
341345
const li = this.createLi(node, node.getLevel());
342-
this.attachNodeData(node, li);
343346

344347
// add element to dom
345348
$previousLi.after(li);

tree.jquery.debug.js

Lines changed: 6 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tree.jquery.debug.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tree.jquery.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tree.jquery.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)