Skip to content

Commit eb1d803

Browse files
authored
Handle open empty folder (#859)
* Handle open empty folder * Changelog
1 parent 8da7a2e commit eb1d803

File tree

3 files changed

+17
-0
lines changed

3 files changed

+17
-0
lines changed

docs/_entries/general/changelog.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@ title: Changelog
33
name: changelog
44
---
55

6+
#### Development version
7+
8+
- Issue #858: load on demand with empty children (thanks to Ivan Kolesov)
9+
610
#### 1.8.7 (november 2 2024)
711

812
- Issue #853: fix dnd to first child (thanks to Oskar von Dungern)

src/test/jqTree/methods.test.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -959,6 +959,15 @@ describe("openNode", () => {
959959
});
960960
});
961961
});
962+
963+
it("handles an empty folder", () => {
964+
const child1 = given.$tree.tree("getNodeByNameMustExist", "child1");
965+
child1.isEmptyFolder = true;
966+
967+
expect(() => {
968+
given.$tree.tree("openNode", child1, false);
969+
}).not.toThrow();
970+
});
962971
});
963972

964973
describe("prependNode", () => {

src/tree.jquery.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -626,6 +626,10 @@ export class JqTreeWidget extends SimpleWidget<JQTreeOptions> {
626626
_slide: boolean,
627627
_onFinished?: OnFinishOpenNode,
628628
): void => {
629+
if (!node.children.length) {
630+
return;
631+
}
632+
629633
const folderElement = this.createFolderElement(_node);
630634
folderElement.open(
631635
_onFinished,

0 commit comments

Comments
 (0)