Skip to content

Commit 1d2d06d

Browse files
committed
♻️ remove 'data' requirement for leave command
- Update leave function to only require ieee parameter - Update service.yaml to remove command_data field - Update zdo.py to use ieee parameter for device lookup - Update debug logging to reflect changes
1 parent 7b24bef commit 1d2d06d

File tree

3 files changed

+6
-20
lines changed

3 files changed

+6
-20
lines changed

custom_components/zha_toolkit/__init__.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -386,9 +386,6 @@
386386
vol.Required(ATTR_IEEE): vol.Any(
387387
cv.entity_id_or_uuid, t.EUI64.convert
388388
),
389-
vol.Required(ATTR_COMMAND_DATA): vol.Any(
390-
cv.entity_id_or_uuid, t.EUI64.convert
391-
),
392389
},
393390
extra=vol.ALLOW_EXTRA,
394391
),

custom_components/zha_toolkit/services.yaml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1753,16 +1753,6 @@ leave:
17531753
selector:
17541754
entity:
17551755
integration: zha
1756-
command_data:
1757-
name: Node to send the Rejoin
1758-
description: >-
1759-
(Parent) Node (router) that removes the device
1760-
of the node)
1761-
example: 00:0d:6f:00:05:7d:2d:34
1762-
required: true
1763-
selector:
1764-
entity:
1765-
integration: zha
17661756
tries:
17671757
name: Tries
17681758
description: Number of times the zigbee packet should be attempted

custom_components/zha_toolkit/zdo.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,30 +17,29 @@ def add_task_info(event_data, task):
1717

1818

1919
async def leave(app, listener, ieee, cmd, data, service, params, event_data):
20-
if ieee is None or not data:
21-
raise ValueError("Need 'ieee' and command_data'")
20+
if ieee is None:
21+
raise ValueError("Need 'ieee'")
2222

2323
LOGGER.debug(
24-
"running 'leave' command. Telling 0x%s to remove %s: %s",
25-
data,
24+
"running 'leave' command. Telling 0x%s to leave %s",
2625
ieee,
2726
service,
2827
)
2928

30-
parent = await u.get_device(app, listener, data)
29+
dev = await u.get_device(app, listener, ieee)
3130

3231
# Get tries
3332
tries = params[p.TRIES]
3433

3534
res = await u.retry_wrapper(
36-
parent.zdo.request,
35+
dev.zdo.request,
3736
zdo_t.ZDOCmd.Mgmt_Leave_req,
3837
ieee,
3938
0x02,
4039
tries=tries,
4140
)
4241
event_data["result_leave"] = res
43-
LOGGER.debug("0x%04x: Mgmt_Leave_req: %s", parent.nwk, res)
42+
LOGGER.debug("0x%04x: Mgmt_Leave_req: %s", dev.nwk, res)
4443

4544

4645
async def ieee_ping(

0 commit comments

Comments
 (0)