-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: Improvements to indexeddb-examples #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @OnkarRuikar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things to consider.
Also, it would be great if we group the five filter inputs and bring the Filter by
on the top.
Co-authored-by: Onkar Khadangale <[email protected]>
Can we do this in a follow-up? It will be easier to review once this cleanup is done |
Simply replace the <form>
<div>
<div>
<input
type="radio"
name="filterIndex"
value="fThing"
id="thing"
checked=""
/>
<label for="thing">Filter by name</label>
</div>
<div>
<input
type="radio"
name="filterIndex"
value="fRating"
id="rating"
/>
<label for="rating">Filter by rating</label>
</div>
</div>
<fieldset>
<div>
<div>
<label for="none">Don't filter values at all</label>
<input
type="radio"
name="value"
value="none"
id="none"
checked=""
/>
</div>
</div>
<div>
<div>
<label for="only">Return <strong>only</strong> one value</label>
<input type="radio" name="value" value="only" id="only" />
</div>
<div>
<label for="onlyText">Key value for single value selection</label>
<input type="text" name="onlyText" id="onlyText" />
</div>
</div>
<div>
<div>
<label for="range"
>Return a <strong>range</strong> of values</label
>
<input type="radio" name="value" value="range" id="range" />
</div>
<div>
<label for="rangeLowerText">Lower limit for range</label>
<input type="text" name="rangeLowerText" id="rangeLowerText" />
</div>
<div>
<label for="rangeUpperText">Upper limit for range</label>
<input type="text" name="rangeUpperText" id="rangeUpperText" />
</div>
</div>
<div>
<div>
<label for="lower"
>Return values with a <strong>lower</strong> bound</label
>
<input type="radio" name="value" value="lower" id="lower" />
</div>
<div>
<label for="lowerBoundText">Lower bound limit for results</label>
<input type="text" name="lowerBoundText" id="lowerBoundText" />
</div>
</div>
<div>
<div>
<label for="upper"
>Return values with an <strong>upper</strong> bound</label
>
<input type="radio" name="value" value="upper" id="upper" />
</div>
<div>
<label for="upperBoundText">Upper bound limit for results</label>
<input type="text" name="upperBoundText" id="upperBoundText" />
</div>
</div>
</fieldset>
<button class="run">Run query</button>
</form> And apply the following CSS: |
Co-authored-by: Onkar Khadangale <[email protected]>
Co-authored-by: Onkar Khadangale <[email protected]>
@bsmth changes look good to me. |
Thanks Onkar, let's merge for now! |
Fixes:
var
->const
/let
Fixes #140