Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid leaking sensitive data, remove "name" attribute from form fields #47

Open
alexsegura opened this issue Aug 20, 2020 · 0 comments
Open

Comments

@alexsegura
Copy link

Hi! Thank you for this component 🙂

When using credit card forms, generally it's a good idea to avoid sending sensitive data to own servers (unless you are PCI/DSS compliant). Currently, the component adds a name attribute to all fields, making it possible to send credit card information to own servers by mistake.

IMHO, adding the name attribute should be opt-in only, for example like this:

getCardNumberProps({ withNameProp: true })

What do you think? This would be a breaking change, requiring a major version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant