chore(core-flows): revert idempotent cart (#13336)

carlos-r-l-rodrigues · web-flow · commit 8176d0f684be · 2025-08-28T22:45:43.000+02:00
diff --git a/.changeset/big-coins-fail.md b/.changeset/big-coins-fail.md
@@ -0,0 +1,5 @@
+---
+"@medusajs/core-flows": patch
+---
+
+chore(core-flows): revert idempotent cart
diff --git a/integration-tests/http/__tests__/promotions/admin/promotions.spec.ts b/integration-tests/http/__tests__/promotions/admin/promotions.spec.ts
@@ -727,6 +727,7 @@ medusaIntegrationTestRunner({
                   storeHeaders
                 )
                 .catch(() => {}),
+              /*
               api
                 .post(
                   `/store/carts/${cart.id}`,
@@ -736,6 +737,7 @@ medusaIntegrationTestRunner({
                   storeHeaders
                 )
                 .catch(() => {}),
+                */
             ])
 
             const cartAfterPromotion = (
diff --git a/packages/core/core-flows/src/cart/workflows/add-to-cart.ts b/packages/core/core-flows/src/cart/workflows/add-to-cart.ts
@@ -116,7 +116,7 @@ export const addToCartWorkflowId = "add-to-cart"
 export const addToCartWorkflow = createWorkflow(
   {
     name: addToCartWorkflowId,
-    idempotent: true,
+    idempotent: false,
   },
   (input: WorkflowData<AddToCartWorkflowInputDTO & AdditionalData>) => {
     const cartQuery = useQueryGraphStep({
diff --git a/packages/core/core-flows/src/cart/workflows/create-payment-collection-for-cart.ts b/packages/core/core-flows/src/cart/workflows/create-payment-collection-for-cart.ts
@@ -81,7 +81,7 @@ export const createPaymentCollectionForCartWorkflowId =
 export const createPaymentCollectionForCartWorkflow = createWorkflow(
   {
     name: createPaymentCollectionForCartWorkflowId,
-    idempotent: true,
+    idempotent: false,
   },
   (
     input: WorkflowData<CreatePaymentCollectionForCartWorkflowInputDTO>
diff --git a/packages/core/core-flows/src/cart/workflows/refresh-cart-items.ts b/packages/core/core-flows/src/cart/workflows/refresh-cart-items.ts
@@ -130,7 +130,7 @@ export const refreshCartItemsWorkflowId = "refresh-cart-items"
 export const refreshCartItemsWorkflow = createWorkflow(
   {
     name: refreshCartItemsWorkflowId,
-    idempotent: true,
+    idempotent: false,
   },
   (input: WorkflowData<RefreshCartItemsWorkflowInput & AdditionalData>) => {
     const setPricingContext = createHook(
diff --git a/packages/core/core-flows/src/cart/workflows/refresh-cart-shipping-methods.ts b/packages/core/core-flows/src/cart/workflows/refresh-cart-shipping-methods.ts
@@ -52,7 +52,7 @@ export const refreshCartShippingMethodsWorkflowId =
 export const refreshCartShippingMethodsWorkflow = createWorkflow(
   {
     name: refreshCartShippingMethodsWorkflowId,
-    idempotent: true,
+    idempotent: false,
   },
   (input: WorkflowData<RefreshCartShippingMethodsWorkflowInput>) => {
     const fetchCart = when("fetch-cart", { input }, ({ input }) => {
diff --git a/packages/core/core-flows/src/cart/workflows/refresh-payment-collection.ts b/packages/core/core-flows/src/cart/workflows/refresh-payment-collection.ts
@@ -56,7 +56,7 @@ export const refreshPaymentCollectionForCartWorkflowId =
 export const refreshPaymentCollectionForCartWorkflow = createWorkflow(
   {
     name: refreshPaymentCollectionForCartWorkflowId,
-    idempotent: true,
+    idempotent: false,
   },
   (input: WorkflowData<RefreshPaymentCollectionForCartWorklowInput>) => {
     const fetchCart = when("should-fetch-cart", { input }, ({ input }) => {
diff --git a/packages/core/core-flows/src/cart/workflows/refund-payment-recreate-payment-session.ts b/packages/core/core-flows/src/cart/workflows/refund-payment-recreate-payment-session.ts
@@ -64,7 +64,7 @@ export const refundPaymentAndRecreatePaymentSessionWorkflowId =
 export const refundPaymentAndRecreatePaymentSessionWorkflow = createWorkflow(
   {
     name: refundPaymentAndRecreatePaymentSessionWorkflowId,
-    idempotent: true,
+    idempotent: false,
   },
   (
     input: WorkflowData<refundPaymentAndRecreatePaymentSessionWorkflowInput>
diff --git a/packages/core/core-flows/src/cart/workflows/transfer-cart-customer.ts b/packages/core/core-flows/src/cart/workflows/transfer-cart-customer.ts
@@ -51,7 +51,7 @@ export const transferCartCustomerWorkflowId = "transfer-cart-customer"
 export const transferCartCustomerWorkflow = createWorkflow(
   {
     name: transferCartCustomerWorkflowId,
-    idempotent: true,
+    idempotent: false,
   },
   (input: WorkflowData<TransferCartCustomerWorkflowInput>) => {
     const cartQuery = useQueryGraphStep({
diff --git a/packages/core/core-flows/src/cart/workflows/update-cart-promotions.ts b/packages/core/core-flows/src/cart/workflows/update-cart-promotions.ts
@@ -75,7 +75,7 @@ export const updateCartPromotionsWorkflowId = "update-cart-promotions"
 export const updateCartPromotionsWorkflow = createWorkflow(
   {
     name: updateCartPromotionsWorkflowId,
-    idempotent: true,
+    idempotent: false,
   },
   (input: WorkflowData<UpdateCartPromotionsWorkflowInput>) => {
     const fetchCart = when("should-fetch-cart", { input }, ({ input }) => {
diff --git a/packages/core/core-flows/src/cart/workflows/update-cart.ts b/packages/core/core-flows/src/cart/workflows/update-cart.ts
@@ -80,7 +80,7 @@ export const updateCartWorkflowId = "update-cart"
 export const updateCartWorkflow = createWorkflow(
   {
     name: updateCartWorkflowId,
-    idempotent: true,
+    idempotent: false,
   },
   (input: WorkflowData<UpdateCartWorkflowInput>) => {
     const { data: cartToUpdate } = useQueryGraphStep({
diff --git a/packages/core/core-flows/src/cart/workflows/update-line-item-in-cart.ts b/packages/core/core-flows/src/cart/workflows/update-line-item-in-cart.ts
@@ -106,7 +106,7 @@ export const updateLineItemInCartWorkflowId = "update-line-item-in-cart"
 export const updateLineItemInCartWorkflow = createWorkflow(
   {
     name: updateLineItemInCartWorkflowId,
-    idempotent: true,
+    idempotent: false,
   },
   (
     input: WorkflowData<UpdateLineItemInCartWorkflowInputDTO & AdditionalData>
diff --git a/packages/core/core-flows/src/line-item/workflows/delete-line-items.ts b/packages/core/core-flows/src/line-item/workflows/delete-line-items.ts
@@ -40,7 +40,7 @@ export const deleteLineItemsWorkflowId = "delete-line-items"
 export const deleteLineItemsWorkflow = createWorkflow(
   {
     name: deleteLineItemsWorkflowId,
-    idempotent: true,
+    idempotent: false,
   },
   (input: WorkflowData<DeleteLineItemsWorkflowInput>) => {
     deleteLineItemsStep(input.ids)

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"@medusajs/core-flows": patch
 +---
++
 +chore(core-flows): revert idempotent cart
Original file line number	Diff line number	Diff line change
`@@ -727,6 +727,7 @@ medusaIntegrationTestRunner({`
`727`	`727`	`storeHeaders`
`728`	`728`	`)`
`729`	`729`	`.catch(() => {}),`
	`730`	`+ /*`
`730`	`731`	`api`
`731`	`732`	`.post(`
`732`	`733`	`/store/carts/${cart.id}`,
`@@ -736,6 +737,7 @@ medusaIntegrationTestRunner({`
`736`	`737`	`storeHeaders`
`737`	`738`	`)`
`738`	`739`	`.catch(() => {}),`
	`740`	`+ */`
`739`	`741`	`])`
`740`	`742`
`741`	`743`	`const cartAfterPromotion = (`
Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,7 @@ export const addToCartWorkflowId = "add-to-cart"`
`116`	`116`	`export const addToCartWorkflow = createWorkflow(`
`117`	`117`	`{`
`118`	`118`	`name: addToCartWorkflowId,`
`119`		`- idempotent: true,`
	`119`	`+ idempotent: false,`
`120`	`120`	`},`
`121`	`121`	`(input: WorkflowData<AddToCartWorkflowInputDTO & AdditionalData>) => {`
`122`	`122`	`const cartQuery = useQueryGraphStep({`
Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ export const createPaymentCollectionForCartWorkflowId =`
`81`	`81`	`export const createPaymentCollectionForCartWorkflow = createWorkflow(`
`82`	`82`	`{`
`83`	`83`	`name: createPaymentCollectionForCartWorkflowId,`
`84`		`- idempotent: true,`
	`84`	`+ idempotent: false,`
`85`	`85`	`},`
`86`	`86`	`(`
`87`	`87`	`input: WorkflowData<CreatePaymentCollectionForCartWorkflowInputDTO>`
Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,7 @@ export const refreshCartItemsWorkflowId = "refresh-cart-items"`
`130`	`130`	`export const refreshCartItemsWorkflow = createWorkflow(`
`131`	`131`	`{`
`132`	`132`	`name: refreshCartItemsWorkflowId,`
`133`		`- idempotent: true,`
	`133`	`+ idempotent: false,`
`134`	`134`	`},`
`135`	`135`	`(input: WorkflowData<RefreshCartItemsWorkflowInput & AdditionalData>) => {`
`136`	`136`	`const setPricingContext = createHook(`
Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ export const refreshCartShippingMethodsWorkflowId =`
`52`	`52`	`export const refreshCartShippingMethodsWorkflow = createWorkflow(`
`53`	`53`	`{`
`54`	`54`	`name: refreshCartShippingMethodsWorkflowId,`
`55`		`- idempotent: true,`
	`55`	`+ idempotent: false,`
`56`	`56`	`},`
`57`	`57`	`(input: WorkflowData<RefreshCartShippingMethodsWorkflowInput>) => {`
`58`	`58`	`const fetchCart = when("fetch-cart", { input }, ({ input }) => {`
Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ export const refreshPaymentCollectionForCartWorkflowId =`
`56`	`56`	`export const refreshPaymentCollectionForCartWorkflow = createWorkflow(`
`57`	`57`	`{`
`58`	`58`	`name: refreshPaymentCollectionForCartWorkflowId,`
`59`		`- idempotent: true,`
	`59`	`+ idempotent: false,`
`60`	`60`	`},`
`61`	`61`	`(input: WorkflowData<RefreshPaymentCollectionForCartWorklowInput>) => {`
`62`	`62`	`const fetchCart = when("should-fetch-cart", { input }, ({ input }) => {`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ export const refundPaymentAndRecreatePaymentSessionWorkflowId =`
`64`	`64`	`export const refundPaymentAndRecreatePaymentSessionWorkflow = createWorkflow(`
`65`	`65`	`{`
`66`	`66`	`name: refundPaymentAndRecreatePaymentSessionWorkflowId,`
`67`		`- idempotent: true,`
	`67`	`+ idempotent: false,`
`68`	`68`	`},`
`69`	`69`	`(`
`70`	`70`	`input: WorkflowData<refundPaymentAndRecreatePaymentSessionWorkflowInput>`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ export const transferCartCustomerWorkflowId = "transfer-cart-customer"`
`51`	`51`	`export const transferCartCustomerWorkflow = createWorkflow(`
`52`	`52`	`{`
`53`	`53`	`name: transferCartCustomerWorkflowId,`
`54`		`- idempotent: true,`
	`54`	`+ idempotent: false,`
`55`	`55`	`},`
`56`	`56`	`(input: WorkflowData<TransferCartCustomerWorkflowInput>) => {`
`57`	`57`	`const cartQuery = useQueryGraphStep({`
Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ export const updateCartPromotionsWorkflowId = "update-cart-promotions"`
`75`	`75`	`export const updateCartPromotionsWorkflow = createWorkflow(`
`76`	`76`	`{`
`77`	`77`	`name: updateCartPromotionsWorkflowId,`
`78`		`- idempotent: true,`
	`78`	`+ idempotent: false,`
`79`	`79`	`},`
`80`	`80`	`(input: WorkflowData<UpdateCartPromotionsWorkflowInput>) => {`
`81`	`81`	`const fetchCart = when("should-fetch-cart", { input }, ({ input }) => {`