Bug(v1): Admin UI is no longer launching on v1.20.11

[adevinwild]

Bug report

The Admin UI is no longer launched on 1.20.11

Describe the bug

The Admin UI is no longer launched on [v1.20.11], this is because this bug I've introduced, sorry 🙌🏼 was missing another fix on the "loadConfig" function

System information

Medusa version (including plugins): v1.20.11

Steps to reproduce the behavior

1. Use v1.20.11
2. Try to launch the app server with the @medusajs/admin plugin enabled
3. Nothing happens

Expected behavior

We should allow a fully configurable serve

Code snippets

I've found a solution, which would explain the logic expressed in the documentation

Instead of doing this :

// packages/admin/src/utils/load-config.ts

// ... for reading purpose

  if (isDev) {
    config = {
      ...config,
      serve: false, // ℹ️ This is problematic
      path: "/",
      backend: "http://localhost:9000",
    }
  }

We should do this :

// packages/admin/src/utils/load-config.ts

// ... for reading purpose

  if (isDev) {
    config = {
      ...config,
      // ✅ We remove the `serve` set to `false` on development mode
      path: "/",
      backend: "http://localhost:9000",
    }
  }

The same goes with the logic a few lines below that one.

// packages/admin/src/utils/load-config.ts

// ...

  if (typeof plugin !== "string") {
    const options = (plugin as { options: PluginOptions }).options ?? {}

    config = {
      serve: isDev ? false : options.serve ?? config.serve, // ℹ️ We also force to `false` here
      // ...

But this should be better :

// packages/admin/src/utils/load-config.ts

// ...

  if (typeof plugin !== "string") {
    const options = (plugin as { options: PluginOptions }).options ?? {}

    config = {
      serve: options.serve ?? config.serve, // ✅ Fully configurable `serve` option
      // ...

Additional context

I've already implemented the solution on a PR that you can find "here"

[kasperkristensen]

Hi @adevinwild, we have released a new version of @medusajs/admin with your fix - 7.1.18.

[adevinwild]

Thanks! I'll warn the community members that had issues lately 🙌🏼