fix(product): Update performance issue #14150
Draft
+168
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 8 Skipped Deployments
|
4 tasks
Contributor
|
Relates to #13783 . We can close the issue after this and the PR for CORE-1296 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
After many runs, we can see that with a medium catalog the performances for updating a product are as follow:
The primary change in this PR addresses a performance issue related to the query strategy used during data fetching.
Previously, the service layer was fetching data without specifying a strategy, which defaulted to the joined strategy. This approach retrieved all related data in a single query with
multiple JOINs, putting significant stress on the database when dealing with large datasets — resulting in substantially increased query times.
The repository layer already had logic to apply pagination based on the input size and force the select-in strategy in those cases. This PR ensures the service layer also leverages
this optimization, preventing the joined strategy from being used when it would be detrimental to performance.
Key improvement: By using the select-in strategy, the database handles smaller, more efficient queries instead of a single heavy JOIN query, dramatically reducing query execution time.