From 5e25b0ff4941ea9033b2077de63cfc646c7983c5 Mon Sep 17 00:00:00 2001 From: Mount-Blanc <102170589+Mount-Blanc@users.noreply.github.com> Date: Thu, 19 May 2022 11:22:13 -0700 Subject: [PATCH 1/2] Added name explanation in README --- README.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 3c005479..1df0fa55 100644 --- a/README.md +++ b/README.md @@ -1,5 +1,9 @@ # Charabia Library used by Meilisearch to tokenize queries and documents +We choose the name of this repository because it starts with char which was done in the same mood as discord or meili, giving the name of the problem we want to solve. +Personally, I don’t feel like it’s an offensive word, but more a funny pun with “char”. +Moreover, other tokenizers don’t always have an understandable name, for instance [lindera](https://github.com/lindera-morphology/lindera) maintained by [@minoru_osuka](https://twitter.com/minoru_osuka) or even [jieba](https://github.com/messense/jieba-rs). +I hope my explanation was clear enough and I hope the name will not discourage you to use or even contribute to the project! 😊 ## Role @@ -71,4 +75,4 @@ let mut segments = orig.segment_str(); assert_eq!(segments.next(), Some("The")); assert_eq!(segments.next(), Some(" ")); assert_eq!(segments.next(), Some("quick")); -``` \ No newline at end of file +``` From 38c62c15e522b2beb3aec7f36999c590b541f8bb Mon Sep 17 00:00:00 2001 From: Mount-Blanc <102170589+Mount-Blanc@users.noreply.github.com> Date: Sat, 28 May 2022 13:35:47 -0700 Subject: [PATCH 2/2] Rewrote name explanation --- README.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 1df0fa55..80651a5d 100644 --- a/README.md +++ b/README.md @@ -1,9 +1,8 @@ # Charabia Library used by Meilisearch to tokenize queries and documents + +## Why Did We Choose This Name? We choose the name of this repository because it starts with char which was done in the same mood as discord or meili, giving the name of the problem we want to solve. -Personally, I don’t feel like it’s an offensive word, but more a funny pun with “char”. -Moreover, other tokenizers don’t always have an understandable name, for instance [lindera](https://github.com/lindera-morphology/lindera) maintained by [@minoru_osuka](https://twitter.com/minoru_osuka) or even [jieba](https://github.com/messense/jieba-rs). -I hope my explanation was clear enough and I hope the name will not discourage you to use or even contribute to the project! 😊 ## Role