Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the Option around the RoTxn internal pointer #317

Closed
Kerollmops opened this issue Mar 5, 2025 · 1 comment
Closed

Remove the Option around the RoTxn internal pointer #317

Kerollmops opened this issue Mar 5, 2025 · 1 comment
Labels
good first issue Good for newcomers
Milestone
v0.22.0 🔑

Comments

@Kerollmops
Copy link
Member

Out of scope but should I really wrap this NonNull into an Option when I am sure that this struct cannot be dropped two times? it's impossible.

Originally posted by @Kerollmops in #315 (comment)
@Kerollmops Kerollmops added this to the v0.22.0 🔑 milestone Mar 5, 2025
@Kerollmops Kerollmops added the good first issue Good for newcomers label Mar 5, 2025
@Kerollmops
Copy link
Member Author

It's better to keep it inside an Option<NonNull> so that we can check in the Drop implementation that we already committed/aborted it.

@Kerollmops Kerollmops closed this as not planned Won't fix, can't repro, duplicate, stale Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
v0.22.0 🔑
Development

No branches or pull requests
1 participant
@Kerollmops