From 257fe84b672c1e23d9d9d881afbf2019150de143 Mon Sep 17 00:00:00 2001 From: Ahmed Fwela Date: Fri, 16 Feb 2024 18:03:21 +0200 Subject: [PATCH 01/10] fix ci steps --- .github/workflows/tests.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 8c961505..8f39a1fc 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -60,6 +60,9 @@ jobs: image: dart:latest steps: - uses: actions/checkout@v3 + - uses: dart-lang/setup-dart@v1 + with: + sdk: '3.0.0' - name: Install dependencies run: dart pub get - name: Run linter @@ -82,6 +85,9 @@ jobs: image: dart:latest steps: - uses: actions/checkout@v3 + - uses: dart-lang/setup-dart@v1 + with: + sdk: '3.0.0' - run: dart pub global activate pana - name: Run pana id: pana-run From 756147bad7a2da7716c48e220a68ec6a3ad9fb87 Mon Sep 17 00:00:00 2001 From: Ahmed Fwela Date: Fri, 16 Feb 2024 18:10:45 +0200 Subject: [PATCH 02/10] update git safe directory --- .github/workflows/tests.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 2bf37595..925cc63f 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -104,10 +104,11 @@ jobs: - uses: dart-lang/setup-dart@v1 with: sdk: '3.0.0' + - run: git config --global --add safe.directory . - run: dart pub global activate pana - name: Run pana id: pana-run - run: | + run: | echo "PANA_OUTPUT<> $GITHUB_ENV dart pub global run pana --no-warning --exit-code-threshold 130 >> $GITHUB_ENV echo "EOF" >> $GITHUB_ENV From fdb903323dc066ce1f92ae0643715fc835b64a76 Mon Sep 17 00:00:00 2001 From: Ahmed Fwela Date: Fri, 16 Feb 2024 18:11:57 +0200 Subject: [PATCH 03/10] yaml format --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 925cc63f..e8f2f8e9 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -108,7 +108,7 @@ jobs: - run: dart pub global activate pana - name: Run pana id: pana-run - run: | + run: | echo "PANA_OUTPUT<> $GITHUB_ENV dart pub global run pana --no-warning --exit-code-threshold 130 >> $GITHUB_ENV echo "EOF" >> $GITHUB_ENV From 429817472b46b9bab5de5007f32c84296c79fef7 Mon Sep 17 00:00:00 2001 From: Ahmed Fwela Date: Fri, 16 Feb 2024 18:12:56 +0200 Subject: [PATCH 04/10] update safe directories again --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index e8f2f8e9..1e846d5f 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -104,7 +104,7 @@ jobs: - uses: dart-lang/setup-dart@v1 with: sdk: '3.0.0' - - run: git config --global --add safe.directory . + - run: git config --global --add safe.directory '*' - run: dart pub global activate pana - name: Run pana id: pana-run From 7c6238b4b808d60856b02498b1d029704ce22a5f Mon Sep 17 00:00:00 2001 From: Ahmed Fwela Date: Fri, 16 Feb 2024 18:14:33 +0200 Subject: [PATCH 05/10] update safe directory x2 --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 1e846d5f..1d19742e 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -104,11 +104,11 @@ jobs: - uses: dart-lang/setup-dart@v1 with: sdk: '3.0.0' - - run: git config --global --add safe.directory '*' - run: dart pub global activate pana - name: Run pana id: pana-run run: | + git config --global --add safe.directory '*' echo "PANA_OUTPUT<> $GITHUB_ENV dart pub global run pana --no-warning --exit-code-threshold 130 >> $GITHUB_ENV echo "EOF" >> $GITHUB_ENV From 5694ce8175846d048bd63f5bb9ee850ae659735a Mon Sep 17 00:00:00 2001 From: Ahmed Fwela Date: Fri, 16 Feb 2024 18:21:38 +0200 Subject: [PATCH 06/10] update safe directory --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 1d19742e..db93b2a7 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -108,7 +108,7 @@ jobs: - name: Run pana id: pana-run run: | - git config --global --add safe.directory '*' + git config --system --add safe.directory '*' echo "PANA_OUTPUT<> $GITHUB_ENV dart pub global run pana --no-warning --exit-code-threshold 130 >> $GITHUB_ENV echo "EOF" >> $GITHUB_ENV From f8081da3c6478527c2551cbe4cc916eab0df71dc Mon Sep 17 00:00:00 2001 From: Ahmed Fwela Date: Fri, 16 Feb 2024 18:24:06 +0200 Subject: [PATCH 07/10] update safe directory --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index db93b2a7..76682b9d 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -101,6 +101,7 @@ jobs: image: dart:latest steps: - uses: actions/checkout@v4 + - run: git config --system --add safe.directory '*' - uses: dart-lang/setup-dart@v1 with: sdk: '3.0.0' @@ -108,7 +109,6 @@ jobs: - name: Run pana id: pana-run run: | - git config --system --add safe.directory '*' echo "PANA_OUTPUT<> $GITHUB_ENV dart pub global run pana --no-warning --exit-code-threshold 130 >> $GITHUB_ENV echo "EOF" >> $GITHUB_ENV From ef04da9952c27df3502f610e0cda241d8581a072 Mon Sep 17 00:00:00 2001 From: Ahmed Fwela Date: Fri, 16 Feb 2024 18:30:31 +0200 Subject: [PATCH 08/10] disable container --- .github/workflows/tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 76682b9d..a516d6cd 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -97,8 +97,8 @@ jobs: pana: runs-on: ubuntu-latest timeout-minutes: 10 - container: - image: dart:latest + # container: + # image: dart:latest steps: - uses: actions/checkout@v4 - run: git config --system --add safe.directory '*' From 0e116befd6f01ba5176d727091ad3dec6afaae2c Mon Sep 17 00:00:00 2001 From: Ahmed Fwela Date: Fri, 16 Feb 2024 18:31:30 +0200 Subject: [PATCH 09/10] remove container in pana --- .github/workflows/tests.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index a516d6cd..58658bab 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -101,7 +101,6 @@ jobs: # image: dart:latest steps: - uses: actions/checkout@v4 - - run: git config --system --add safe.directory '*' - uses: dart-lang/setup-dart@v1 with: sdk: '3.0.0' From f3dbb46c9eb3b41f19e458c6d2f5956a734030de Mon Sep 17 00:00:00 2001 From: Ahmed Fwela Date: Fri, 16 Feb 2024 18:33:15 +0200 Subject: [PATCH 10/10] final improvements --- .github/workflows/tests.yml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 58658bab..6c577134 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -61,9 +61,6 @@ jobs: image: dart:latest steps: - uses: actions/checkout@v4 - - uses: dart-lang/setup-dart@v1 - with: - sdk: '3.0.0' - name: Install dependencies run: | dart pub get @@ -97,8 +94,6 @@ jobs: pana: runs-on: ubuntu-latest timeout-minutes: 10 - # container: - # image: dart:latest steps: - uses: actions/checkout@v4 - uses: dart-lang/setup-dart@v1